Conversation
…r function that was causing error thrown in certain cases when browser tabs were opened
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
@metamask/chain-agnostic-permission with fix to helper function that was causing error thrown in certain cases when browser tabs were opened
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
|
|
Contributor
|
ffmcgee725
approved these changes
Jun 17, 2025
@metamask/chain-agnostic-permission with fix to helper function that was causing error thrown in certain cases when browser tabs were opened@metamask/chain-agnostic-permission with fix to helper function that was causing error thrown in certain cases when browser tabs were opened
jiexi
approved these changes
Jun 17, 2025
Contributor
|
Approved for cherry pick into 7.49.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core PR with fix to
isInternalAccountInPermittedAccountIds&isCaipAccountIdInPermittedAccountIdswhich was causing this bug.Bumps
@metamask/chain-agnostic-permissionto latest:0.7.1Related issues
See slack thread where bug was initially reported
Screenshots/Recordings
Before
Screen.Recording.2025-06-13.at.5.45.15.PM.mov
After
Screen.Recording.2025-06-13.at.6.49.45.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist