feat: 2.6 seedless multi-srp ui by ieow · Pull Request #16009 · MetaMask/metamask-mobile

ieow · 2025-06-03T04:32:52Z

Description

The Seedless Multi-SRP UI simplifies account access by replacing traditional seed phrases with multiple secure recovery methods, enhancing both security and user experience
Figma Link: http://figma.com/design/pViOUcmjwhEzFsdrwknpNc/Onboarding-redesign?node-id=2717-121956&m=dev

Related issues

Fixes:

Manual testing steps

Go to the app.
Click on create wallet button
Click on any social login, i.e. Apple or Google login.

Screenshots/Recordings

Before

After

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-06-03T04:33:06Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

remove unwanted lint changes

- Added OnboardingSheet component for user onboarding options. - Integrated AccountStatus component to handle existing account scenarios. - Updated navigation routes to include new onboarding flows. - Enhanced ChoosePassword component to support OAuth login success handling. - Updated localization files to include new strings for onboarding and account status. - Added tests for new components and updated existing tests for integration. This commit enhances the user experience during onboarding and account management by providing clear options and feedback for existing users.

…nd Authentication components

…ion and restoration

…ntication module

Co-authored-by: Ganesh Suresh Patra <ganesh.patra@consensys.net>

…s onboarding behavior

github-actions · 2025-07-10T10:26:16Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 688b89a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f798b4b1-3c58-43a9-b7be-bfbd311f5ddf

Note

You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

cursor · 2025-07-10T10:52:27Z

🚨 BugBot couldn't run

Something went wrong. Try again by commenting "bugbot run", or contact support (requestId: serverGenReqId_d6848e8b-e3ef-4de2-b02c-16c81b4082bf).

github-actions · 2025-07-10T11:32:25Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 9005a12
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a2f1d862-31a2-4f4a-939f-12774af074ff

Note

You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

cursor

Bug: Incorrect Seed Format Passed to Backup Function

The addNewSeedPhraseBackup function is called with an incorrect data format. The seed variable, created from inputCodePoints (which contains BIP39 word indices as a Uint16Array), passes raw word index bytes instead of the actual cryptographic seed derived from the mnemonic. The backup function expects the proper seed bytes/entropy. Additionally, the variable name seed is misleading.

app/actions/multiSrp/index.ts#L75-L89

metamask-mobile/app/actions/multiSrp/index.ts

Lines 75 to 89 in 070deae

    
           // TODO: to use loginCompleted 
        
           if (selectSeedlessOnboardingLoginFlow(ReduxService.store.getState())) { 
        
             // on Error, wallet should notify user that the newly added seed phrase is not synced properly 
        
             // user can try manual sync again (phase 2) 
        
             const seed = new Uint8Array(inputCodePoints.buffer); 
        
             try { 
        
               await SeedlessOnboardingController.addNewSeedPhraseBackup( 
        
                 seed, 
        
                 newKeyring.id, 
        
               ); 
        
             } catch (error) { 
        
               // Log the error but don't let it crash the import process 
        
               console.error('Failed to backup seed phrase:', error); 
        
             } 
        
           }

Fix in Cursor • Fix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

github-actions · 2025-07-10T12:48:07Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 070deae
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d0cb35fe-d2ab-45b0-8d0d-0b63065a9020

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

sonarqubecloud · 2025-07-10T13:01:17Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
92.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

metamaskbot added the team-onboarding Onboarding team label Jun 3, 2025

ieow and others added 18 commits June 26, 2025 11:26

feat: clean up oauth service

6613043

remove unwanted lint changes

fix: remove build flag

d1465f8

fix: remove unused added assets

e08a4ca

fix: oauth config

9554498

chore: address comment

6a7aca4

fix : check for getBundleId

78bc655

fix: default ios google client bundleid

ee72c36

fix: remove oauth env from js.env.example

20b3a03

fix: add OTHER_METHODS_BUTTON selector to LoginView

f929f36

feat: remove seedless onboarding Build Flag from Login, Onboarding, a…

0eecdd9

…nd Authentication components

fix: update snapshot

375660c

test: enhance Login component tests with authentication scenarios

ebbeaab

fix: Failing tests in Onboarding view after merge

d365d5d

test: enhance App component tests with onboarding navigation scenarios

a4649ef

test: add tests for SOLANA_DISCOVERY_PENDING handling in wallet creat…

db0af35

…ion and restoration

test: add rehydrateSeedPhrase tests for seed phrase handling in Authe…

368ff2c

…ntication module

fix: seedless onboarding runtime env

6cea7a3

ieow force-pushed the feat/seedless-change-pw-ui branch from f9e1627 to 426bc0c Compare June 30, 2025 06:05

feat: multi-srp

d08fbac

Co-authored-by: Ganesh Suresh Patra <ganesh.patra@consensys.net>

ieow force-pushed the feat/seedless-multi-srp-sync branch from bb73b24 to d08fbac Compare June 30, 2025 06:53

huggingbot and others added 7 commits June 30, 2025 19:39

test: enhance Onboarding tests with OAuth login scenarios and seedles…

4b17a02

…s onboarding behavior

feat: init with default state when env is not enabled

e4109ff

feat: buildtype mapping

e9f01e2

feat: browser bff apple flow

938221f

fix: address comment

be70766

Merge branch 'feat/new-srp-oauth-service' into feat/seedless-oauth-flow

9de4ee4

fix: update config

1ca4d2c

This comment was marked as outdated.

Sign in to view

Merge branch 'main' into feat/seedless-multi-srp-sync

688b89a

This comment was marked as outdated.

Sign in to view

hieu-w added Run Smoke E2E and removed Run Smoke E2E labels Jul 10, 2025

fix: commet review changes

9005a12

chaitanyapotti added No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E and removed Run Smoke E2E labels Jul 10, 2025

hieu-w added Run Smoke E2E and removed Run Smoke E2E labels Jul 10, 2025

Merge branch 'main' into feat/seedless-multi-srp-sync

070deae

cursor Bot reviewed Jul 10, 2025

View reviewed changes

chaitanyapotti added Run Smoke E2E and removed Run Smoke E2E labels Jul 10, 2025

metamaskbot added the bitrise-result-ready label Jul 10, 2025

github-actions Bot removed the bitrise-result-ready label Jul 10, 2025

ieow enabled auto-merge July 10, 2025 13:36

chaitanyapotti approved these changes Jul 10, 2025

View reviewed changes

ieow added this pull request to the merge queue Jul 10, 2025

Merged via the queue into main with commit 51f98d6 Jul 10, 2025
53 of 57 checks passed

ieow deleted the feat/seedless-multi-srp-sync branch July 10, 2025 14:25

github-actions Bot locked and limited conversation to collaborators Jul 10, 2025

metamaskbot added the release-7.52.0 Issue or pull request that will be included in release 7.52.0 label Jul 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: 2.6 seedless multi-srp ui#16009

feat: 2.6 seedless multi-srp ui#16009
ieow merged 124 commits into
mainfrom
feat/seedless-multi-srp-sync

ieow commented Jun 3, 2025 •

edited by smgv

Loading

Uh oh!

github-actions Bot commented Jun 3, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions Bot commented Jul 10, 2025 •

edited by metamaskbot

Loading

Uh oh!

cursor Bot commented Jul 10, 2025

Uh oh!

github-actions Bot commented Jul 10, 2025 •

edited by metamaskbot

Loading

Uh oh!

cursor Bot left a comment

Uh oh!

github-actions Bot commented Jul 10, 2025 •

edited by metamaskbot

Loading

Uh oh!

sonarqubecloud Bot commented Jul 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

	// TODO: to use loginCompleted
	if (selectSeedlessOnboardingLoginFlow(ReduxService.store.getState())) {
	// on Error, wallet should notify user that the newly added seed phrase is not synced properly
	// user can try manual sync again (phase 2)
	const seed = new Uint8Array(inputCodePoints.buffer);
	try {
	await SeedlessOnboardingController.addNewSeedPhraseBackup(
	seed,
	newKeyring.id,
	);
	} catch (error) {
	// Log the error but don't let it crash the import process
	console.error('Failed to backup seed phrase:', error);
	}
	}

Uh oh!

Conversation

ieow commented Jun 3, 2025 • edited by smgv Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions Bot commented Jun 3, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions Bot commented Jul 10, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

cursor Bot commented Jul 10, 2025

🚨 BugBot couldn't run

Uh oh!

github-actions Bot commented Jul 10, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Bug: Incorrect Seed Format Passed to Backup Function

Uh oh!

github-actions Bot commented Jul 10, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

sonarqubecloud Bot commented Jul 10, 2025

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

ieow commented Jun 3, 2025 •

edited by smgv

Loading

github-actions Bot commented Jul 10, 2025 •

edited by metamaskbot

Loading

github-actions Bot commented Jul 10, 2025 •

edited by metamaskbot

Loading

github-actions Bot commented Jul 10, 2025 •

edited by metamaskbot

Loading