Skip to content

test: resolve failing smoke tests caused Solana integration#15382

Merged
Andepande merged 3 commits into
feat/solana-code-fencesfrom
solana-codefence-e2e-fix
May 16, 2025
Merged

test: resolve failing smoke tests caused Solana integration#15382
Andepande merged 3 commits into
feat/solana-code-fencesfrom
solana-codefence-e2e-fix

Conversation

@Andepande

@Andepande Andepande commented May 16, 2025

Copy link
Copy Markdown
Contributor

Description

Got it! Here's an updated PR description that includes those details:


Fixes existing smoke E2E test failures that occur when the Solana feature is enabled.

  • Suppresses the Solana feature sheet for tests that use fixtures.
  • For tests that don’t use fixtures, automatically swipes down to dismiss the modal.

This ensures stability across smoke tests regardless of the Solana feature flag state.


Let me know if you'd like to mention specific test files or tag reviewers.

Related issues

Fixes:

https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1a3fd4be-4f11-42b7-a2a7-a6c8b14f399a

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Andepande Andepande requested a review from cortisiko May 16, 2025 07:19
@metamaskbot metamaskbot added the team-qa QA team label May 16, 2025
@Andepande Andepande added No QA Needed Apply this label when your PR does not need any QA effort. and removed team-qa QA team labels May 16, 2025
@github-actions

github-actions Bot commented May 16, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: e9ac676
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/aab203d4-8e9c-4051-bcda-fec993079ba0

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label May 16, 2025
@sonarqubecloud

Copy link
Copy Markdown

@aganglada aganglada left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but tests are still failing no?

@Andepande Andepande merged commit abcfa8f into feat/solana-code-fences May 16, 2025
51 of 55 checks passed
@Andepande Andepande deleted the solana-codefence-e2e-fix branch May 16, 2025 07:54
@github-actions github-actions Bot locked and limited conversation to collaborators May 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template No QA Needed Apply this label when your PR does not need any QA effort.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants