Skip to content

chore(runway): cherry-pick fix: bump bridge controllers and update quote response fields#15376

Merged
NicolasMassart merged 3 commits into
release/7.47.0from
cherry-pick-144352d
May 16, 2025
Merged

chore(runway): cherry-pick fix: bump bridge controllers and update quote response fields#15376
NicolasMassart merged 3 commits into
release/7.47.0from
cherry-pick-144352d

Conversation

@runway-github

@runway-github runway-github Bot commented May 15, 2025

Copy link
Copy Markdown
Contributor

Description

This PR bumps the versions of bridge-controller and
bridge-status-controller to fix an issue with the dev APIs and the
field priceData

Related issues

Fixes:

Manual testing steps

  1. Go to Bridge
  2. Fetch a quote
  3. Quote should load successfully

Screenshots/Recordings

Before

After

n/a, non-user facing change

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots. 144352d

…ds (#15300)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

This PR bumps the versions of `bridge-controller` and
`bridge-status-controller` to fix an issue with the dev APIs and the
field `priceData`

Fixes:

1. Go to Bridge
2. Fetch a quote
3. Quote should load successfully

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

<!-- [screenshots/recordings] -->

<!-- [screenshots/recordings] -->

n/a, non-user facing change

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@runway-github runway-github Bot requested a review from a team as a code owner May 15, 2025 22:10
@runway-github runway-github Bot requested a review from a team May 15, 2025 22:10
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-runway-bot-deprecated DEPRECATED: please use "team-bots" instead label May 15, 2025
@socket-security

socket-security Bot commented May 15, 2025

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​bridge-status-controller@​18.0.0 ⏵ 20.0.090 +71007599 +1100
Updatednpm/​@​metamask/​bridge-controller@​21.0.0 ⏵ 23.0.0911007699 +1100

View full report

@github-actions

github-actions Bot commented May 16, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 868299a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/53da3317-927d-4410-a249-c335bdea1db3

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sonarqubecloud

Copy link
Copy Markdown

@NicolasMassart NicolasMassart enabled auto-merge (squash) May 16, 2025 15:31
@NicolasMassart NicolasMassart merged commit d3dd5a5 into release/7.47.0 May 16, 2025
27 of 28 checks passed
@NicolasMassart NicolasMassart deleted the cherry-pick-144352d branch May 16, 2025 15:32
@github-actions github-actions Bot locked and limited conversation to collaborators May 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

team-runway-bot-deprecated DEPRECATED: please use "team-bots" instead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants