feat: add multi-SRP EVM Account Syncing#15357
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
|
|
|
|
cmd-ob
left a comment
There was a problem hiding this comment.
Looks good. One small question about reducing the base timeout.
mirceanis
left a comment
There was a problem hiding this comment.
Looks good.
I'm concerned about the overload of 'has synced at least once', though.
Can you take a look at the question I left?



Description
This PR implements the core changes seen in this PR.
In short, this changes the implementation of
AuthenticationControllerso that it can manage parallel sessions based onentropySource.In turn, this addition permits
UserStorageControllerto scope user storage requests to a specificentropySource.Using all those changes, account syncing now iterates over each
entropySourcepresent in the client and syncs accounts in consequence. This will ensure that each SRP has its own data, that can be synced independently of the context (e.g Device 1 (SRP 1 + SRP 2), Device 2 (SRP 2 only) will bi-directionally sync).Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist