Skip to content

refactor: cp-7.46.0 fix account list flakes in e2e tests(#15206)#15328

Merged
NicolasMassart merged 1 commit into
release/7.46.0from
cherry-pick-7.46.0-e3b9fc27afe84017bbaa841a74aa40be7775177a
May 14, 2025
Merged

refactor: cp-7.46.0 fix account list flakes in e2e tests(#15206)#15328
NicolasMassart merged 1 commit into
release/7.46.0from
cherry-pick-7.46.0-e3b9fc27afe84017bbaa841a74aa40be7775177a

Conversation

@cmd-ob

@cmd-ob cmd-ob commented May 14, 2025

Copy link
Copy Markdown
Contributor

Description

The action to select and account from the account list, or when long pressing for removing accounts. This was tapping on the select-with-menu previously which was tapping the middle of the account list element i.e wallet address.

I have raised this low severity
bug

This

Related issues

Fixes:

Manual testing steps

  1. Go to this page... 2.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Description

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…#15206)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
The action to select and account from the account list, or when long
pressing for removing accounts. This was tapping on the
`select-with-menu` previously which was tapping the middle of the
account list element i.e wallet address.

I have raised this [low severity
bug](#15205)

This 
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label May 14, 2025
@NicolasMassart NicolasMassart merged commit 98173a7 into release/7.46.0 May 14, 2025
32 of 33 checks passed
@NicolasMassart NicolasMassart deleted the cherry-pick-7.46.0-e3b9fc27afe84017bbaa841a74aa40be7775177a branch May 14, 2025 13:39
@github-actions github-actions Bot locked and limited conversation to collaborators May 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants