Description

Migration files should never be removed once added, as this creates a mismatch between the the number of the final migration and the total number of migrations, and so new migrations that are added later could be skipped.

This commit adds back migration 73, which was removed in a previous commit, except that it replaces it with a version that does nothing.

Related issues

Fixes #15306.

Manual testing steps

• Check out this branch.
• Open app/store/migrations/index.ts and comment out the final migration (78).
• Open app/store/persistConfig.ts and change migrate: createMigrate(migrations, { debug: false }), to migrate: createMigrate(migrations, { debug: true }),.
• Run yarn setup:expo and yarn watch:clean.
• Remove the app from your device or local emulator first (you can also simply clear all app storage on Android).
• Open the app, go through onboarding, and create an account.
• Now reopen app/store/migrations/index.ts and uncomment migration 78 so that it will run.
• Reload the app.
• Look for a line starting with redux-persist. You should see that migration 78 ran (not 77).

Screenshots/Recordings

Before

After

This is what you should see:

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.