Skip to content

fix: (cp-7.46.0) network switcher - use additional checks for non-evm networks#15283

Merged
Prithpal-Sooriya merged 9 commits into
mainfrom
fix/ensure-toHex-uses-evm-networks
May 14, 2025
Merged

fix: (cp-7.46.0) network switcher - use additional checks for non-evm networks#15283
Prithpal-Sooriya merged 9 commits into
mainfrom
fix/ensure-toHex-uses-evm-networks

Conversation

@Prithpal-Sooriya

@Prithpal-Sooriya Prithpal-Sooriya commented May 12, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

I have not been able to replicate this bug, but this is some additional checks to ensure we are correctly checking against EVM networks and ignore non-EVM networks.

We already added checks into main from #15184
^ However this targets @metamask/multichain-network-controller@^0.4.0, whereas the RC uses 0.3.0

Related issues

Fixes: #15272

Manual testing steps

N/A, I still haven't figured out how to repro this.

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

github-actions Bot commented May 12, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Prithpal-Sooriya Prithpal-Sooriya force-pushed the fix/ensure-toHex-uses-evm-networks branch from e89a10d to 6297691 Compare May 12, 2025 15:12
@github-actions

github-actions Bot commented May 12, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 6297691
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8ea5d170-8302-4511-8040-0f5e87e64b6a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Prithpal-Sooriya

Prithpal-Sooriya commented May 13, 2025

Copy link
Copy Markdown
Contributor Author

I think I'm in favour of closing this fix for this already merged fix:
#15184

NicolasMassart
NicolasMassart requested changes May 13, 2025
View reviewed changes

@NicolasMassart NicolasMassart left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a unit test for CustomNetwork please?
I know there's no test file already, but adding one could be a good way to make sure we deal with all the cases.

@Prithpal-Sooriya Prithpal-Sooriya changed the title fix: network switcher - use additional checks for non-evm networks fix: (cp-7.46.0) network switcher - use additional checks for non-evm networks May 13, 2025
@Prithpal-Sooriya Prithpal-Sooriya marked this pull request as ready for review May 13, 2025 17:41
@Prithpal-Sooriya Prithpal-Sooriya requested a review from a team as a code owner May 13, 2025 17:41
@Prithpal-Sooriya

Prithpal-Sooriya commented May 13, 2025

Copy link
Copy Markdown
Contributor Author

@NicolasMassart tests added.

This technically is already fixed in main through #15184.
This is just some additional checks for 7.46.0.

@github-actions

github-actions Bot commented May 13, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: ad98cc1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2af3e757-823f-45a8-a70d-38bafea6520f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

gambinish
gambinish previously approved these changes May 13, 2025
View reviewed changes
@gambinish gambinish added the QA Passed QA testing has been completed and passed label May 13, 2025
@github-actions

github-actions Bot commented May 13, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 0b2ed59
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/669a37d9-575c-4913-a69f-dae351f3e85f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@github-actions

github-actions Bot commented May 14, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8f9dadb
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a8c1eb64-3564-47db-8e2f-939a1d08ca6c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

NicolasMassart
NicolasMassart reviewed May 14, 2025
View reviewed changes
Comment thread ...nts/Views/Settings/NetworksSettings/NetworkSettings/CustomNetworkView/CustomNetwork.test.tsx
Comment thread ...nts/Views/Settings/NetworksSettings/NetworkSettings/CustomNetworkView/CustomNetwork.test.tsx Outdated
NicolasMassart
NicolasMassart approved these changes May 14, 2025
View reviewed changes

@NicolasMassart NicolasMassart left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@sonarqubecloud

sonarqubecloud Bot commented May 14, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@NicolasMassart NicolasMassart added the No QA Needed Apply this label when your PR does not need any QA effort. label May 14, 2025
@NicolasMassart

NicolasMassart commented May 14, 2025

Copy link
Copy Markdown
Contributor

I added the no-qa-needed as e2e tests passed initially but started failing after update with main, the e2e are the cause, not the code in this PR. The changes after the passing e2e are only unit tests.

@Prithpal-Sooriya Prithpal-Sooriya added this pull request to the merge queue May 14, 2025
Merged via the queue into main with commit 11a3678 May 14, 2025
47 of 48 checks passed
@Prithpal-Sooriya Prithpal-Sooriya deleted the fix/ensure-toHex-uses-evm-networks branch May 14, 2025 11:52
@github-actions github-actions Bot locked and limited conversation to collaborators May 14, 2025
@metamaskbot metamaskbot added the release-7.48.0 Issue or pull request that will be included in release 7.48.0 label May 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@NicolasMassart NicolasMassart NicolasMassart approved these changes

@NidhiKJha NidhiKJha NidhiKJha approved these changes

@gambinish gambinish gambinish left review comments

Assignees

No one assigned

Labels

No QA Needed Apply this label when your PR does not need any QA effort. QA Passed QA testing has been completed and passed release-7.48.0 Issue or pull request that will be included in release 7.48.0 team-assets

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error: Invalid character

5 participants

@Prithpal-Sooriya @NicolasMassart @gambinish @NidhiKJha @metamaskbot