Skip to content

fix: fix error when no pricePercentageChange found#15230

Merged
sahar-fehri merged 1 commit into
mainfrom
fix/fix-error-when-no-percentage-change-found
May 8, 2025
Merged

fix: fix error when no pricePercentageChange found#15230
sahar-fehri merged 1 commit into
mainfrom
fix/fix-error-when-no-percentage-change-found

Conversation

@sahar-fehri

@sahar-fehri sahar-fehri commented May 8, 2025

Copy link
Copy Markdown
Contributor

Description

Fixes error that occurs when we do not get pricePercentChange in marketData from snap.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

Screenshot 2025-05-08 at 11 15 30

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

github-actions Bot commented May 8, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri sahar-fehri marked this pull request as ready for review May 8, 2025 09:11
@sahar-fehri sahar-fehri requested a review from a team as a code owner May 8, 2025 09:11
@github-actions

github-actions Bot commented May 8, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: e335c06
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/be8f8278-85e9-4768-806f-cd1c9aa3636b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sahar-fehri sahar-fehri added the No QA Needed Apply this label when your PR does not need any QA effort. label May 8, 2025
@sonarqubecloud

sonarqubecloud Bot commented May 8, 2025

Copy link
Copy Markdown

@sahar-fehri sahar-fehri changed the title fix: fix error when no pricePErcentageChange found fix: fix error when no pricePercentageChange found May 8, 2025
@sahar-fehri sahar-fehri enabled auto-merge May 8, 2025 11:32
@sahar-fehri sahar-fehri added this pull request to the merge queue May 8, 2025
Merged via the queue into main with commit fc5e020 May 8, 2025
58 of 64 checks passed
@sahar-fehri sahar-fehri deleted the fix/fix-error-when-no-percentage-change-found branch May 8, 2025 14:43
@github-actions github-actions Bot locked and limited conversation to collaborators May 8, 2025
@metamaskbot metamaskbot added the release-7.47.0 Issue or pull request that will be included in release 7.47.0 label May 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.47.0 Issue or pull request that will be included in release 7.47.0 team-assets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants