Skip to content

feat: Solana dapp connectivity announcement toast#15224

Merged
owencraston merged 8 commits into
mainfrom
feat/solana-dapp-connection-coming-soon
May 9, 2025
Merged

feat: Solana dapp connectivity announcement toast#15224
owencraston merged 8 commits into
mainfrom
feat/solana-dapp-connection-coming-soon

Conversation

@owencraston

@owencraston owencraston commented May 7, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Render a toast indicating that solana dapp connectivity is coming soon when a user opens the in app browser and their current account is a Solana account.

Design is here: https://www.figma.com/design/VqbOpEAsKGogdhZ5IsL4Pu/Solana?m=auto&node-id=2771-7777&t=IUlpwfo4owE10Ybw-1

Related issues

Fixes: #14563

Manual testing steps

  1. ensure that you are building beta by editing your METAMASK_BUILD_TYPE to beta in the .js.env file
  2. import or create a wallet
  3. create a solona account
  4. ensure that the solana account is selected
  5. navigate to the browser
  6. you should see the Toast that matches the designs pop up
  7. now navigate back to the wallet view and select an ethereum account
  8. navigate back to the browser
  9. notice that the toast does not pop up

Screenshots/Recordings

Before

After

Screenshot 2025-05-08 at 9 42 31 PM
screen-20250508-212013.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

github-actions Bot commented May 7, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-accounts-framework Accounts team label May 7, 2025
@owencraston owencraston changed the title trigger toast feat: Add toast when users tries to connect to a Solana dapp whilst on a Solana account May 7, 2025
@codecov-commenter

codecov-commenter commented May 7, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 72.72727% with 6 lines in your changes missing coverage. Please review.

Project coverage is 68.60%. Comparing base (5113000) to head (98aae76).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
app/components/Views/Browser/index.js 72.72% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15224      +/-   ##
==========================================
+ Coverage   68.46%   68.60%   +0.14%     
==========================================
  Files        2372     2375       +3     
  Lines       51275    51298      +23     
  Branches     7634     7635       +1     
==========================================
+ Hits        35103    35193      +90     
+ Misses      13942    13870      -72     
- Partials     2230     2235       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@owencraston owencraston force-pushed the feat/solana-dapp-connection-coming-soon branch from 6988243 to 4773a74 Compare May 8, 2025 20:23
@owencraston owencraston marked this pull request as ready for review May 8, 2025 20:44
@owencraston owencraston force-pushed the feat/solana-dapp-connection-coming-soon branch from 379e1d4 to d0a70a2 Compare May 8, 2025 21:28
@github-actions

github-actions Bot commented May 8, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: d0a70a20a283a1542dfe68fad9f03bc7b84ca2e3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c4d011ec-3d5d-481b-92d7-5065dc409056

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@owencraston owencraston changed the title feat: Add toast when users tries to connect to a Solana dapp whilst on a Solana account feat: Add toast indicating Solana dapp connectivity is coming soon when users opens the Browser whilst on a Solana account May 8, 2025
owencraston
owencraston commented May 8, 2025
View reviewed changes
Comment thread app/components/Views/Browser/index.js Outdated
owencraston
owencraston commented May 8, 2025
View reviewed changes
Comment thread app/components/Views/Browser/index.js Outdated
@owencraston owencraston changed the title feat: Add toast indicating Solana dapp connectivity is coming soon when users opens the Browser whilst on a Solana account feat: Solana dapp connectivity announcement toast May 9, 2025
@gantunesr gantunesr mentioned this pull request May 9, 2025
Closed
7 tasks
@owencraston owencraston force-pushed the feat/solana-dapp-connection-coming-soon branch from d0a70a2 to f8d7e2e Compare May 9, 2025 14:45
@github-actions

github-actions Bot commented May 9, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: f8d7e2e6ed7827b70da4fc7f033aefe0a97319bc
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1fc2bdf3-60a5-4c41-a9fd-efe8ee44a789

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@owencraston owencraston enabled auto-merge May 9, 2025 15:01
@owencraston owencraston added the No QA Needed Apply this label when your PR does not need any QA effort. label May 9, 2025
@owencraston owencraston force-pushed the feat/solana-dapp-connection-coming-soon branch from f8d7e2e to 56b95c6 Compare May 9, 2025 16:03
@github-actions

github-actions Bot commented May 9, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 56b95c6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c55fc675-7071-4284-b6c1-395f6d4d6c26

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud

sonarqubecloud Bot commented May 9, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
88.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@owencraston owencraston added this pull request to the merge queue May 9, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 9, 2025
@owencraston owencraston added this pull request to the merge queue May 9, 2025
Merged via the queue into main with commit 748d3dc May 9, 2025
49 of 51 checks passed
@owencraston owencraston deleted the feat/solana-dapp-connection-coming-soon branch May 9, 2025 17:39
@github-actions github-actions Bot locked and limited conversation to collaborators May 9, 2025
@metamaskbot metamaskbot added the release-7.48.0 Issue or pull request that will be included in release 7.48.0 label May 9, 2025
@NicolasMassart NicolasMassart added release-7.47.0 Issue or pull request that will be included in release 7.47.0 and removed release-7.48.0 Issue or pull request that will be included in release 7.48.0 labels May 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@gantunesr gantunesr gantunesr approved these changes

Assignees

No one assigned

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.47.0 Issue or pull request that will be included in release 7.47.0 team-accounts-framework Accounts team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[UX Improvement] Add toast when users tries to connect to a Solana dapp whilst on a Solana account

5 participants

@owencraston @codecov-commenter @gantunesr @NicolasMassart @metamaskbot