Skip to content

fix: only show SRP pill when we have multiple SRPs#15217

Merged
gantunesr merged 1 commit into
mainfrom
fix/srp-pills
May 7, 2025
Merged

fix: only show SRP pill when we have multiple SRPs#15217
gantunesr merged 1 commit into
mainfrom
fix/srp-pills

Conversation

@ccharly

@ccharly ccharly commented May 7, 2025 •
edited by owencraston
Loading

Copy link
Copy Markdown
Contributor

Description

We were showing the SRP pill for Solana accounts even when we add only 1 SRP (== 1 HD keyring).

Related issues

Fixes: https://github.com/MetaMask/accounts-planning/issues/926

Manual testing steps

  1. Create a Solana account
  2. It should not have any SRP pill showing up
  3. Import a new SRP
  4. You should now see an SRP pills under HD accounts and Solana accounts

Screenshots/Recordings

Before

Screenshot 2025-05-07 at 19 16 09

After

Screenshot 2025-05-07 at 19 22 45
Screenshot 2025-05-07 at 19 24 14
Screenshot 2025-05-07 at 19 24 41

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@ccharly ccharly self-assigned this May 7, 2025
@github-actions

github-actions Bot commented May 7, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-accounts-framework Accounts team label May 7, 2025
@ccharly ccharly added No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E labels May 7, 2025
@ccharly ccharly marked this pull request as ready for review May 7, 2025 17:30
@github-actions

github-actions Bot commented May 7, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 049c95f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b5975677-68c6-4dd1-bd81-a6f1ec2aeb36

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@gantunesr gantunesr enabled auto-merge May 7, 2025 17:37
@sonarqubecloud

sonarqubecloud Bot commented May 7, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
85.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@gantunesr gantunesr added this pull request to the merge queue May 7, 2025
Merged via the queue into main with commit 1c7aedd May 7, 2025
58 of 63 checks passed
@gantunesr gantunesr deleted the fix/srp-pills branch May 7, 2025 18:25
@github-actions github-actions Bot locked and limited conversation to collaborators May 7, 2025
@metamaskbot metamaskbot added the release-7.47.0 Issue or pull request that will be included in release 7.47.0 label May 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@gantunesr gantunesr gantunesr approved these changes

@owencraston owencraston owencraston approved these changes

Assignees

@ccharly ccharly

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.47.0 Issue or pull request that will be included in release 7.47.0 team-accounts-framework Accounts team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ccharly @gantunesr @owencraston @metamaskbot