Skip to content

fix: 15108 create a wrapper for toChecksumAddress to prevent app crash#15202

Merged
NicolasMassart merged 6 commits into
release/7.45.2from
fix/15108-send-flow-v7.45.1
May 7, 2025
Merged

fix: 15108 create a wrapper for toChecksumAddress to prevent app crash#15202
NicolasMassart merged 6 commits into
release/7.45.2from
fix/15108-send-flow-v7.45.1

Conversation

@dawnseeker8

@dawnseeker8 dawnseeker8 commented May 7, 2025

Copy link
Copy Markdown
Contributor

create a wrapper for toChecksumAddress to prevent app crash on address validation

Description

Related issues

Fixes: #15108

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

github-actions Bot commented May 7, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-hardware-wallets-deprecated DEPRECATED: please use "team-accounts-framework" instead label May 7, 2025
@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@dawnseeker8 dawnseeker8 marked this pull request as ready for review May 7, 2025 13:40
@dawnseeker8 dawnseeker8 requested review from a team as code owners May 7, 2025 13:40
@github-actions

github-actions Bot commented May 7, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e9ae089
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8e21514c-5e15-41c6-916f-ecb0bcc06e10

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@dawnseeker8 dawnseeker8 requested a review from a team as a code owner May 7, 2025 15:32
@NicolasMassart NicolasMassart enabled auto-merge (squash) May 7, 2025 17:33
@sonarqubecloud

sonarqubecloud Bot commented May 7, 2025

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
76.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@NicolasMassart NicolasMassart merged commit 54e9abd into release/7.45.2 May 7, 2025
32 of 37 checks passed
@NicolasMassart NicolasMassart deleted the fix/15108-send-flow-v7.45.1 branch May 7, 2025 17:37
@github-actions github-actions Bot locked and limited conversation to collaborators May 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

team-hardware-wallets-deprecated DEPRECATED: please use "team-accounts-framework" instead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants