Skip to content

fix: don't push up the token selector modal when keyboard is open#15197

Merged
infiniteflower merged 2 commits into
mainfrom
mms-2386-bridge-keyboard-overlap
May 7, 2025
Merged

fix: don't push up the token selector modal when keyboard is open#15197
infiniteflower merged 2 commits into
mainfrom
mms-2386-bridge-keyboard-overlap

Conversation

@infiniteflower

@infiniteflower infiniteflower commented May 6, 2025

Copy link
Copy Markdown
Contributor

Description

This PR fixes an issue where the Bridge token selector modal would be pushed upwards when you pressed on the text input field and the keyboard opens up.

Related issues

Fixes: #15103

Manual testing steps

  1. Go to Bridge
  2. Open the source token selector
  3. Try to search for a token
  4. You should be able to search

Screenshots/Recordings

Before

After

Screen.Recording.2025-05-06.at.5.10.13.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

github-actions Bot commented May 6, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-swaps-and-bridge Swaps and Bridge team label May 6, 2025
@infiniteflower infiniteflower marked this pull request as ready for review May 6, 2025 21:11
@infiniteflower infiniteflower requested a review from a team as a code owner May 6, 2025 21:11
@github-actions

github-actions Bot commented May 6, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 6677b87
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bcf58981-3f93-4dbe-8600-1afd74da6262

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@infiniteflower infiniteflower enabled auto-merge May 6, 2025 21:12
amitabh94
amitabh94 previously approved these changes May 6, 2025
@github-actions

github-actions Bot commented May 7, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a8bf6f6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c1290540-8163-4bbc-969c-3cdc84506c55

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud

sonarqubecloud Bot commented May 7, 2025

Copy link
Copy Markdown

@infiniteflower infiniteflower added this pull request to the merge queue May 7, 2025
Merged via the queue into main with commit d942e97 May 7, 2025
45 of 51 checks passed
@infiniteflower infiniteflower deleted the mms-2386-bridge-keyboard-overlap branch May 7, 2025 14:52
@github-actions github-actions Bot locked and limited conversation to collaborators May 7, 2025
@metamaskbot metamaskbot added the release-7.47.0 Issue or pull request that will be included in release 7.47.0 label May 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.47.0 Issue or pull request that will be included in release 7.47.0 team-swaps-and-bridge Swaps and Bridge team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: In Solana Swap flow, when trying to type in the 'Select token' field, the field is out of view

3 participants