Skip to content

fix: Updated useComponentSize to re-render on change#15188

Merged
georgewrmarshall merged 7 commits into
mainfrom
fix/usecomponentsize
May 7, 2025
Merged

fix: Updated useComponentSize to re-render on change#15188
georgewrmarshall merged 7 commits into
mainfrom
fix/usecomponentsize

Conversation

@brianacnguyen

@brianacnguyen brianacnguyen commented May 6, 2025

Copy link
Copy Markdown
Contributor

Description

This PR updated the useComponentSize hook to re-render on change.

Related issues

Fixes: #15187

Manual testing steps

  1. Go to browser
  2. Connect to dapp
  3. Check network badge

Screenshots/Recordings

Before

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-05-06.at.09.29.13.mp4

After

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-05-06.at.09.29.55.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen self-assigned this May 6, 2025
@brianacnguyen brianacnguyen requested a review from a team as a code owner May 6, 2025 17:04
@brianacnguyen brianacnguyen added team-design-system All issues relating to design system in Mobile Run Smoke E2E labels May 6, 2025
@github-actions

github-actions Bot commented May 6, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions

github-actions Bot commented May 6, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: a451e4a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3d1e4a31-e688-4a23-a46d-55820c011a0b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@brianacnguyen brianacnguyen added the No QA Needed Apply this label when your PR does not need any QA effort. label May 6, 2025
Prithpal-Sooriya
Prithpal-Sooriya reviewed May 6, 2025
View reviewed changes
Comment thread app/component-library/hooks/useComponentSize.ts
Prithpal-Sooriya
Prithpal-Sooriya reviewed May 6, 2025
View reviewed changes
Comment thread app/component-library/hooks/useComponentSize.ts
@EtherWizard33 EtherWizard33 self-requested a review May 6, 2025 17:41
EtherWizard33
EtherWizard33 previously approved these changes May 6, 2025
View reviewed changes

@EtherWizard33 EtherWizard33 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions

github-actions Bot commented May 6, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 1944f99
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d2241f73-ded2-4158-acc3-8e7838f18215

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@github-actions

github-actions Bot commented May 6, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: f1cbb6b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b8220c2a-3043-42a2-a383-b1b015d55229

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@georgewrmarshall georgewrmarshall enabled auto-merge May 6, 2025 23:46
@EtherWizard33 EtherWizard33 self-requested a review May 7, 2025 11:55
@github-actions

github-actions Bot commented May 7, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 7fd8aa2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/aa892069-9a74-484e-8abc-76a1027b8068

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud

sonarqubecloud Bot commented May 7, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@georgewrmarshall georgewrmarshall added this pull request to the merge queue May 7, 2025
Merged via the queue into main with commit 975186f May 7, 2025
77 of 79 checks passed
@georgewrmarshall georgewrmarshall deleted the fix/usecomponentsize branch May 7, 2025 13:21
@github-actions github-actions Bot locked and limited conversation to collaborators May 7, 2025
@metamaskbot metamaskbot added the release-7.47.0 Issue or pull request that will be included in release 7.47.0 label May 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Prithpal-Sooriya Prithpal-Sooriya Prithpal-Sooriya approved these changes

@georgewrmarshall georgewrmarshall georgewrmarshall approved these changes

+1 more reviewer

@EtherWizard33 EtherWizard33 EtherWizard33 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@brianacnguyen brianacnguyen

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.47.0 Issue or pull request that will be included in release 7.47.0 team-design-system All issues relating to design system in Mobile

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: useComponentSize not updating when values changed

5 participants

@brianacnguyen @georgewrmarshall @Prithpal-Sooriya @EtherWizard33 @metamaskbot