Skip to content

feat: Make standalone confirmations redirect to transactions view#15106

Merged
OGPoyraz merged 3 commits into
mainfrom
ogp/4816
May 7, 2025
Merged

feat: Make standalone confirmations redirect to transactions view#15106
OGPoyraz merged 3 commits into
mainfrom
ogp/4816

Conversation

@OGPoyraz

@OGPoyraz OGPoyraz commented May 5, 2025

Copy link
Copy Markdown
Member

Description

This PR aims to redirect all redesigned standalone confirmations to the transactions view.

So instead of just staking confirmations, redirect all standalone confirmations.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4816

Manual testing steps

Only possible to test it out via setting FEATURE_FLAG_REDESIGNED_TRANSFER to true, so can be skipped manual test for now.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz OGPoyraz added No QA Needed Apply this label when your PR does not need any QA effort. team-confirmations Push issues to confirmations team no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed labels May 5, 2025
@OGPoyraz OGPoyraz requested a review from a team as a code owner May 5, 2025 06:06
@github-actions

github-actions Bot commented May 5, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 5786f6c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/27c7fce5-9037-4648-ac3b-2e80c2231f94

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Comment thread app/selectors/featureFlagController/confirmations/index.ts
@github-actions

github-actions Bot commented May 5, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 814da3d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/09c52b1e-9048-4797-8057-e3c0c181c2f1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud

sonarqubecloud Bot commented May 5, 2025

Copy link
Copy Markdown

@OGPoyraz OGPoyraz added this pull request to the merge queue May 7, 2025
Merged via the queue into main with commit bfbb320 May 7, 2025
51 checks passed
@OGPoyraz OGPoyraz deleted the ogp/4816 branch May 7, 2025 05:59
@github-actions github-actions Bot locked and limited conversation to collaborators May 7, 2025
@metamaskbot metamaskbot added the release-7.47.0 Issue or pull request that will be included in release 7.47.0 label May 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

No QA Needed Apply this label when your PR does not need any QA effort. no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.47.0 Issue or pull request that will be included in release 7.47.0 team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants