Skip to content

fix: base-x audit issue#15087

Merged
tommasini merged 1 commit into
mainfrom
fix/base-x-audit-issue
May 2, 2025
Merged

fix: base-x audit issue#15087
tommasini merged 1 commit into
mainfrom
fix/base-x-audit-issue

Conversation

@tommasini

Copy link
Copy Markdown
Contributor

Description

Fix for GHSA-xq7p-g2vc-g82p

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform Mobile Platform team Run Smoke E2E labels May 2, 2025
@tommasini tommasini requested a review from a team May 2, 2025 19:31
@github-project-automation github-project-automation Bot moved this to Needs dev review in PR review queue May 2, 2025
@github-actions

github-actions Bot commented May 2, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions

github-actions Bot commented May 2, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 5d8a58f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6026423c-1c8c-40e1-b955-2f9331b35b10

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud

sonarqubecloud Bot commented May 2, 2025

Copy link
Copy Markdown

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation Bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue May 2, 2025
@tommasini tommasini added this pull request to the merge queue May 2, 2025
Merged via the queue into main with commit 6a0b457 May 2, 2025
52 of 60 checks passed
@tommasini tommasini deleted the fix/base-x-audit-issue branch May 2, 2025 20:49
@github-project-automation github-project-automation Bot moved this from Review finalised - Ready to be merged to Merged, Closed or Archived in PR review queue May 2, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators May 2, 2025
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 2, 2025
@metamaskbot metamaskbot added the release-7.47.0 Issue or pull request that will be included in release 7.47.0 label May 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.47.0 Issue or pull request that will be included in release 7.47.0 team-mobile-platform Mobile Platform team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants