Skip to content

fix: use AddNewAccount for account creation in SolanaNewFeatureContent#15001

Merged
montelaidev merged 5 commits into
mainfrom
fix/mmmultisrp-136
May 7, 2025
Merged

fix: use AddNewAccount for account creation in SolanaNewFeatureContent#15001
montelaidev merged 5 commits into
mainfrom
fix/mmmultisrp-136

Conversation

@montelaidev

Copy link
Copy Markdown
Contributor

Description

This PR updates SolanaNewFeature to use AddNewAccount

Changes:

  1. SolanaNewFeature to navigate to AddNewAccount when create account has been pressed.

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMMULTISRP-136?atlOrigin=eyJpIjoiOTc3OTg4ZmQwM2NmNGMyZWE0MDE2MWQ5YzIyM2ZjYzkiLCJwIjoiaiJ9

Manual testing steps

Using the beta build

  1. Go through the onboarding
  2. See the SolanaNewFeature modal
  3. Click create account and see the modal popup.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@montelaidev montelaidev added the team-accounts-framework Accounts team label Apr 30, 2025
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@montelaidev montelaidev requested a review from a team April 30, 2025 10:37
@github-actions

github-actions Bot commented Apr 30, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 0500c57
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/54818a79-6858-42f7-8a42-0dd06d738edf

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@montelaidev montelaidev requested a review from a team April 30, 2025 12:51
@montelaidev montelaidev changed the title fix: use AddNewAccount for account creation in SolanaNewFeatureContent fix: use AddNewAccount for account creation in SolanaNewFeatureContent cp-7.47.0 May 7, 2025
@montelaidev montelaidev enabled auto-merge May 7, 2025 00:24
@sonarqubecloud

sonarqubecloud Bot commented May 7, 2025

Copy link
Copy Markdown

@montelaidev montelaidev changed the title fix: use AddNewAccount for account creation in SolanaNewFeatureContent cp-7.47.0 fix: use AddNewAccount for account creation in SolanaNewFeatureContent May 7, 2025
@DostoevskysPiano DostoevskysPiano added the QA Passed QA testing has been completed and passed label May 7, 2025
@montelaidev montelaidev added this pull request to the merge queue May 7, 2025
Merged via the queue into main with commit 83d3100 May 7, 2025
45 of 46 checks passed
@montelaidev montelaidev deleted the fix/mmmultisrp-136 branch May 7, 2025 22:03
@github-actions github-actions Bot locked and limited conversation to collaborators May 7, 2025
@metamaskbot metamaskbot added the release-7.47.0 Issue or pull request that will be included in release 7.47.0 label May 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

QA Passed QA testing has been completed and passed release-7.47.0 Issue or pull request that will be included in release 7.47.0 team-accounts-framework Accounts team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants