Skip to content

feat: create solana account and call discoverAccounts during creation and import of hd keyring#14775

Merged
montelaidev merged 60 commits into
mainfrom
feat/mmmultisrp-165
May 8, 2025
Merged

feat: create solana account and call discoverAccounts during creation and import of hd keyring#14775
montelaidev merged 60 commits into
mainfrom
feat/mmmultisrp-165

Conversation

@montelaidev

@montelaidev montelaidev commented Apr 22, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR enables the discover Accounts call during import srp and creation of a new vault.

Changes:

  1. update multiSrp/index to call addDiscoveredAccounts and add tests.
  2. Updates SolanaNewFeatureContent.test.tsx to use the MultichainWalletSnapFactory
  3. Refactor name logic into a separate file getMultichainAccountName in AddNewAccount
  4. In Authentication addDiscoveredAccounts is called after createNewVaultandRestore and createNewVaultAndKeychain

Related issues

Fixes:

Manual testing steps

Using the beta build.

Onboarding flow

  1. With a new MM instance, create a new vault.
  2. See that there is a new solana account along with the ethereum account.

Import new srp during onboarding

  1. With a new MM instance, import a new srp
  2. See that there is a new solana account along with the ethereum account.

With an existing MM vault.

  1. Click on account selector.
  2. Click on Secrete Recovery Phrase
  3. Add a new srp.
  4. See that there is a new solana account created after the import.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@montelaidev
refactor: AddNewAccount
eb0709f
@montelaidev
fix: update import and selector id name
b599527
@montelaidev
feat: add multisrp to beta
14e3bb0
@montelaidev
fix: add account labels
dfd941d
@montelaidev
fix: add account redirect
efd4abf
@montelaidev
fix: test
c317d38
@montelaidev
fix: capitalize account
e512541
@montelaidev
feat: add test for client creation
5216f27
@montelaidev
fix: remove unused.
913c579
@montelaidev
Merge remote-tracking branch 'origin/main' into fix/multichain-accoun…
dd0a2b2 
…t-keyring-selection
@montelaidev
chore: update changelog
29afd66
@montelaidev
fix: changelog
f4e0aef
@montelaidev
fix: remove unused
ed1bafc
@montelaidev
fix: deps in callback
dc514f5
@montelaidev
fix: solana account creation with multi srp
2401ec5
@montelaidev
fix: changelog
a5ff1eb
@montelaidev
fix: tests
66f6b6a
@montelaidev
chore: remove unused
bfd7809
@montelaidev
refactor: client to MultichainWalletSnapFactory
329896e
@montelaidev
Merge remote-tracking branch 'origin/main' into fix/mmmultisrp-129
88eb4b2
@montelaidev
Merge remote-tracking branch 'origin/main' into fix/mmmultisrp-129
06757af
@montelaidev
fix: disable button while loading
7a916ec
@montelaidev
fix: test
fa9a816
@montelaidev
fix: test
9885aa5
@montelaidev
fix: update changelog
6e7e39a
@montelaidev
feat: add tests to MultichainWalletSnapClient
5da6ffa
@montelaidev
fix: use scopes from keyringapi
e9236b2
@montelaidev
fix: use scope from keyring api
070a8c8
@montelaidev
feat: add discover after vault creation
ea0a926
@montelaidev
revert: test
cf6e1e1
@codecov-commenter

codecov-commenter commented Apr 30, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 88.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 67.85%. Comparing base (cf99fce) to head (0f88b78).

Files with missing lines Patch % Lines
app/core/SnapKeyring/MultichainWalletSnapClient.ts 77.77% 3 Missing and 1 partial ⚠️
...core/SnapKeyring/utils/getMultichainAccountName.ts 90.90% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #14775      +/-   ##
==========================================
+ Coverage   67.81%   67.85%   +0.03%     
==========================================
  Files        2339     2340       +1     
  Lines       50384    50405      +21     
  Branches     7427     7431       +4     
==========================================
+ Hits        34168    34202      +34     
+ Misses      14052    14036      -16     
- Partials     2164     2167       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@montelaidev montelaidev enabled auto-merge April 30, 2025 05:55
@montelaidev montelaidev changed the title feat: create solana account and call discoverAccounts during creation and import of hd keyring feat: create solana account and call discoverAccounts during creation and import of hd keyring cp-7.46.0 Apr 30, 2025
@montelaidev montelaidev changed the title feat: create solana account and call discoverAccounts during creation and import of hd keyring cp-7.46.0 feat: create solana account and call discoverAccounts during creation and import of hd keyring cp-7.47.0 May 7, 2025
@montelaidev montelaidev requested a review from a team May 7, 2025 01:02
@montelaidev montelaidev force-pushed the feat/mmmultisrp-165 branch from 341417f to 3d1dc7b Compare May 7, 2025 01:03
@github-actions

github-actions Bot commented May 7, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 3d1dc7b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4e6bca89-94f5-4ac8-9da6-a044bc7b5cf5

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@montelaidev montelaidev changed the title feat: create solana account and call discoverAccounts during creation and import of hd keyring cp-7.47.0 feat: create solana account and call discoverAccounts during creation and import of hd keyring May 7, 2025
@sonarqubecloud

sonarqubecloud Bot commented May 7, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
86.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

owencraston
owencraston approved these changes May 8, 2025
View reviewed changes

@owencraston owencraston left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the import and with an existing MM vault flow and it worked as expected. The code also looks good to me.

screen-20250508-200436.2.mp4

@montelaidev montelaidev added this pull request to the merge queue May 8, 2025
Merged via the queue into main with commit 23e30d0 May 8, 2025
40 checks passed
@montelaidev montelaidev deleted the feat/mmmultisrp-165 branch May 8, 2025 19:29
@github-actions github-actions Bot locked and limited conversation to collaborators May 8, 2025
@metamaskbot metamaskbot added the release-7.48.0 Issue or pull request that will be included in release 7.48.0 label May 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@owencraston owencraston owencraston approved these changes

Assignees

@montelaidev montelaidev

Labels

QA Passed QA testing has been completed and passed release-7.48.0 Issue or pull request that will be included in release 7.48.0 team-accounts-framework Accounts team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@montelaidev @codecov-commenter @owencraston @metamaskbot @DostoevskysPiano @Andepande