Skip to content

chore: Update the icon assets with new set of icons#14733

Merged
georgewrmarshall merged 17 commits into
mainfrom
feat/icons
May 7, 2025
Merged

chore: Update the icon assets with new set of icons#14733
georgewrmarshall merged 17 commits into
mainfrom
feat/icons

Conversation

@brianacnguyen

@brianacnguyen brianacnguyen commented Apr 17, 2025

Copy link
Copy Markdown
Contributor

Description

This PR updates the icon asset library with the new set of icons

Related issues

Fixes: #14452

Manual testing steps

  1. Check everywhere to make sure icons are functional

Screenshots/Recordings

Before

After

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-04-17.at.15.03.34.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-design-system All issues relating to design system in Mobile Run Smoke E2E labels Apr 17, 2025
@brianacnguyen brianacnguyen self-assigned this Apr 17, 2025
@brianacnguyen brianacnguyen requested review from a team as code owners April 17, 2025 22:14
@github-project-automation github-project-automation Bot moved this to Needs dev review in PR review queue Apr 17, 2025
@github-actions

github-actions Bot commented Apr 17, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions

github-actions Bot commented Apr 17, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: f704468
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fce15845-ccf3-4c0e-a704-2c27ada49fbb

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

brianacnguyen
brianacnguyen commented Apr 23, 2025
View reviewed changes
Comment thread app/component-library/components/Icons/Icon/Icon.tsx
Comment thread ...-library/components/Badges/Badge/variants/BadgeNotifications/BadgeNotifications.constants.ts
Comment thread app/components/UI/Notification/NotificationMenuItem/Icon.test.tsx
sahar-fehri
sahar-fehri previously approved these changes Apr 23, 2025
View reviewed changes
@github-actions

github-actions Bot commented Apr 23, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: ccfda35
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/906edd71-6ee1-4d1e-8528-e1cd04f571f0

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

darkwing
darkwing previously approved these changes May 7, 2025
View reviewed changes
@georgewrmarshall georgewrmarshall enabled auto-merge May 7, 2025 21:45
@github-actions

github-actions Bot commented May 7, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 8d0903f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a62f4f3b-8379-4aad-bd6e-48939703ee44

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@github-actions

github-actions Bot commented May 7, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 6c529ca
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3e8193f7-4e02-4271-b29a-a33d64e8b33f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud

sonarqubecloud Bot commented May 7, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@georgewrmarshall georgewrmarshall added this pull request to the merge queue May 7, 2025
Merged via the queue into main with commit ce320cf May 7, 2025
49 of 51 checks passed
@georgewrmarshall georgewrmarshall deleted the feat/icons branch May 7, 2025 23:19
@github-project-automation github-project-automation Bot moved this from Review finalised - Ready to be merged to Merged, Closed or Archived in PR review queue May 7, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators May 7, 2025
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 7, 2025
@metamaskbot metamaskbot added the release-7.47.0 Issue or pull request that will be included in release 7.47.0 label May 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@georgewrmarshall georgewrmarshall georgewrmarshall approved these changes

@sahar-fehri sahar-fehri sahar-fehri left review comments

@cortisiko cortisiko cortisiko left review comments

@Prithpal-Sooriya Prithpal-Sooriya Prithpal-Sooriya left review comments

+1 more reviewer

@darkwing darkwing darkwing approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@brianacnguyen brianacnguyen

Labels

QA Passed QA testing has been completed and passed release-7.47.0 Issue or pull request that will be included in release 7.47.0 team-design-system All issues relating to design system in Mobile

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[MOB] Update icon library with new icons

9 participants

@brianacnguyen @amandaye0h @codecov-commenter @darkwing @georgewrmarshall @sahar-fehri @cortisiko @Prithpal-Sooriya @metamaskbot