Skip to content

fix: display multichain accounts in srp list#14724

Merged
montelaidev merged 14 commits into
mainfrom
fix/mmmultisrp-171
May 7, 2025
Merged

fix: display multichain accounts in srp list#14724
montelaidev merged 14 commits into
mainfrom
fix/mmmultisrp-171

Conversation

@montelaidev

@montelaidev montelaidev commented Apr 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR fix the accounts list in the SRP list to show multichain accounts.

Changes:

  1. New hook useHdKeyringsWithSnapAccounts
  2. Update SRPList to use the new hook

Related issues

Fixes:

Manual testing steps

  1. Go to account menu
  2. Add a new srp
  3. Create a new solana account
  4. Go to Reveal SRP
  5. Click on select srp
  6. See that the accounts displayed includes the solana account.

Screenshots/Recordings

Before

After

Screenshot 2025-04-17 at 22 05 54

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

github-actions Bot commented Apr 17, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-accounts-framework Accounts team label Apr 17, 2025
@montelaidev montelaidev marked this pull request as ready for review April 17, 2025 14:07
@github-actions

github-actions Bot commented Apr 17, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 2d11a0e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/da2b0e3d-f0cd-43b2-beca-41b5c07b28f7

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@github-actions

github-actions Bot commented Apr 22, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 5243c67
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9e5dbc82-1963-43a9-b9c9-9ffb4cedef99

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@montelaidev montelaidev requested a review from a team April 22, 2025 14:24
@montelaidev montelaidev enabled auto-merge April 24, 2025 15:54
@gantunesr

gantunesr commented Apr 24, 2025

Copy link
Copy Markdown
Member

Couple of bugs

  • The account list shows the same identicon for all addresses
  • The bottom of the component can't be reached

gantunesr
gantunesr reviewed Apr 24, 2025
View reviewed changes

@gantunesr gantunesr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments, this must have E2E since this PR changes the flow to access the SRPs

Comment thread CHANGELOG.md Outdated
Comment thread app/components/hooks/useHdKeyringsWithSnapAccounts.ts Outdated
montelaidev and others added 3 commits April 28, 2025 14:55
@montelaidev @gantunesr
Update CHANGELOG.md
369a603 
Co-authored-by: Gustavo Antunes <17601467+gantunesr@users.noreply.github.com>
@montelaidev
fix: use avatar component
a9d1f89
@montelaidev
fix: update hook logic
f16676e
@montelaidev

montelaidev commented Apr 28, 2025

Copy link
Copy Markdown
Contributor Author

For the second issue, i can't seem to replicate it. I can scroll down to the next srp.

Couple of bugs

  • The account list shows the same identicon for all addresses
* The bottom of the component can't be reached

@montelaidev montelaidev requested a review from gantunesr April 28, 2025 11:23
@github-actions

github-actions Bot commented Apr 29, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 675b03d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/646fc6a8-2a6f-4d32-adc0-483280de279a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Andepande Andepande added the QA Passed QA testing has been completed and passed label Apr 29, 2025
@montelaidev montelaidev changed the title fix: display multichain accounts in srp list fix: display multichain accounts in srp list cp-7.47.0 May 7, 2025
@sonarqubecloud

sonarqubecloud Bot commented May 7, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
93.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@montelaidev montelaidev added this pull request to the merge queue May 7, 2025
@montelaidev montelaidev changed the title fix: display multichain accounts in srp list cp-7.47.0 fix: display multichain accounts in srp list May 7, 2025
Merged via the queue into main with commit e75ec76 May 7, 2025
42 checks passed
@montelaidev montelaidev deleted the fix/mmmultisrp-171 branch May 7, 2025 14:22
@github-actions github-actions Bot locked and limited conversation to collaborators May 7, 2025
@metamaskbot metamaskbot added the release-7.47.0 Issue or pull request that will be included in release 7.47.0 label May 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@gantunesr gantunesr gantunesr approved these changes

Assignees

No one assigned

Labels

QA Passed QA testing has been completed and passed release-7.47.0 Issue or pull request that will be included in release 7.47.0 team-accounts-framework Accounts team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@montelaidev @gantunesr @metamaskbot @DostoevskysPiano @Andepande