Skip to content

chore: cp-7.45.1 bump @metamask/keyring-controller to ^21.0.4#14702

Merged
NicolasMassart merged 6 commits intomainfrom
mikesposito/bumps/keyring-controller
Apr 25, 2025
Merged

chore: cp-7.45.1 bump @metamask/keyring-controller to ^21.0.4#14702
NicolasMassart merged 6 commits intomainfrom
mikesposito/bumps/keyring-controller

Conversation

@mikesposito
Copy link
Copy Markdown
Member

@mikesposito mikesposito commented Apr 16, 2025 •
edited
Loading

Description

Updating @metamask/keyring-controller to ^21.0.4

## [21.0.4]

### Fixed

- Ensure no duplicate accounts are persisted ([#5710](https://github.com/MetaMask/core/pull/5710))

## [21.0.3]

### Changed

- `ExportableKeyEncryptor` is now a generic type with a type parameter `EncryptionKey` ([#5395](https://github.com/MetaMask/core/pull/5395))
  - The type parameter defaults to `unknown`

### Fixed

- Fixed wrong error message thrown when using the wrong password ([#5627](https://github.com/MetaMask/core/pull/5627))

## [21.0.2]

### Changed

- Bump `@metamask/keyring-api` from `^17.2.0` to `^17.4.0` ([#5565](https://github.com/MetaMask/core/pull/5565))
- Bump `@metamask/keyring-internal-api` from `^6.0.0` to `^6.0.1` ([#5565](https://github.com/MetaMask/core/pull/5565))

### Fixed

- Ignore cached encryption key when the vault needs to upgrade its encryption parameters ([#5601](https://github.com/MetaMask/core/pull/5601))

Related issues

Fixes: #14228

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@mikesposito mikesposito requested a review from a team April 16, 2025 16:55
@socket-security
Copy link
Copy Markdown

socket-security bot commented Apr 16, 2025 •
edited
Loading

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​keyring-controller@​21.0.1 ⏵ 21.0.4941007698 +1100

View full report

@metamaskbot metamaskbot added the team-wallet-framework-deprecated DEPRECATED: please use "team-core-platform" instead label Apr 16, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 16, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: dc14fda
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c0e457be-d337-4af0-b599-0a4027cf6577

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

mikesposito
mikesposito commented Apr 25, 2025
View reviewed changes
@mikesposito mikesposito changed the title chore: bump @metamask/keyring-controller to ^21.0.3 chore: bump @metamask/keyring-controller to ^21.0.4 Apr 25, 2025
@mikesposito mikesposito changed the title chore: bump @metamask/keyring-controller to ^21.0.4 fix: bump @metamask/keyring-controller to ^21.0.4 Apr 25, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 25, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

NicolasMassart
NicolasMassart approved these changes Apr 25, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@NicolasMassart NicolasMassart changed the title fix: bump @metamask/keyring-controller to ^21.0.4 chore: cp-7.25.0 bump @metamask/keyring-controller to ^21.0.4 Apr 25, 2025
@NicolasMassart NicolasMassart mentioned this pull request Apr 25, 2025
Closed
7 tasks
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 25, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@NicolasMassart NicolasMassart added this pull request to the merge queue Apr 25, 2025
Merged via the queue into main with commit 6de2b94 Apr 25, 2025
42 checks passed
@NicolasMassart NicolasMassart deleted the mikesposito/bumps/keyring-controller branch April 25, 2025 13:45
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2025
@metamaskbot metamaskbot added the release-7.47.0 Issue or pull request that will be included in release 7.47.0 label Apr 25, 2025
@NicolasMassart NicolasMassart changed the title chore: cp-7.25.0 bump @metamask/keyring-controller to ^21.0.4 chore: cp-7.45.1 bump @metamask/keyring-controller to ^21.0.4 Apr 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@NicolasMassart NicolasMassart NicolasMassart approved these changes

Assignees

No one assigned

Labels

release-7.47.0 Issue or pull request that will be included in release 7.47.0 team-wallet-framework-deprecated DEPRECATED: please use "team-core-platform" instead

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Sentry] Error: KeyringController - keyring metadata length mismatch

3 participants

@mikesposito @NicolasMassart @metamaskbot