Skip to content

chore: allow fixtures to be used with appium and BrowserStack#14684

Merged
christopherferreira9 merged 2 commits into
mainfrom
christopher/allow-appium-fixtures
Apr 15, 2025
Merged

chore: allow fixtures to be used with appium and BrowserStack#14684
christopherferreira9 merged 2 commits into
mainfrom
christopher/allow-appium-fixtures

Conversation

@christopherferreira9

@christopherferreira9 christopherferreira9 commented Apr 15, 2025

Copy link
Copy Markdown
Contributor

Description

Allows the use of fixtures with Appium by providing a fallback to load the state from the BrowserStack localhost equivalent.

Related issues

Fixes:

Manual testing steps

Tested with both Android and iOS manually through BrowserStack app automate.

Screenshots/Recordings

video-c4abcb63d056e036153f0843da4849d18f8f217a.mp4

Before

Fixtures would not load when using appium.

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@christopherferreira9 christopherferreira9 marked this pull request as draft April 15, 2025 17:35
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Apr 15, 2025
@github-actions

github-actions Bot commented Apr 15, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 1b6f6be
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f1f8f946-e088-4f97-83e9-b2aae4c63c00

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud

Copy link
Copy Markdown

@christopherferreira9 christopherferreira9 changed the title chore: allows fixtures to be used with appium apps chore: allows fixtures to be used with appium Apr 15, 2025
@christopherferreira9 christopherferreira9 marked this pull request as ready for review April 15, 2025 19:08
@christopherferreira9 christopherferreira9 changed the title chore: allows fixtures to be used with appium chore: allow fixtures to be used with appium Apr 15, 2025
@christopherferreira9 christopherferreira9 changed the title chore: allow fixtures to be used with appium chore: allow fixtures to be used with appium and BrowserStack Apr 15, 2025

@cortisiko cortisiko left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮 🌮 🌮

@christopherferreira9 christopherferreira9 added this pull request to the merge queue Apr 15, 2025
Merged via the queue into main with commit 68d4900 Apr 15, 2025
@christopherferreira9 christopherferreira9 deleted the christopher/allow-appium-fixtures branch April 15, 2025 21:03
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 15, 2025
@metamaskbot metamaskbot added the release-7.46.0 Issue or pull request that will be included in release 7.46.0 label Apr 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.46.0 Issue or pull request that will be included in release 7.46.0 team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants