Skip to content

chore: bump profile-sync-controller to ^12.0.0 and notification-services-controller to ^6.0.0#14675

Merged
mathieuartu merged 4 commits into
mainfrom
chore/bump-identity-notifications-controllers
Apr 15, 2025
Merged

chore: bump profile-sync-controller to ^12.0.0 and notification-services-controller to ^6.0.0#14675
mathieuartu merged 4 commits into
mainfrom
chore/bump-identity-notifications-controllers

Conversation

@mathieuartu

@mathieuartu mathieuartu commented Apr 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR bumps:

  • @metamak/profile-sync-controller to ^12.0.0
    • This introduces a new UserStorageController state property: isAccountSyncingEnabled. This defaults to true.
    • More info on the introduced changes can be found here
  • @metamask/notification-services-controller to 6.0.0

Related issues

Fixes:

Manual testing steps

  1. No user facing changes should be introduced by this PR, but verifying that account syncing still works correctly can still be done.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@mathieuartu mathieuartu added the team-identity-deprecated DEPRECATED: team no longer exists label Apr 15, 2025
@mathieuartu mathieuartu self-assigned this Apr 15, 2025
@github-actions

github-actions Bot commented Apr 15, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security

socket-security Bot commented Apr 15, 2025 •
edited
Loading

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​profile-sync-controller@​11.0.0 ⏵ 12.0.091 +710086100100
Updatednpm/​@​metamask/​notification-services-controller@​5.0.1 ⏵ 6.0.093 +610087100100

View full report

@github-actions

github-actions Bot commented Apr 15, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: de60f11
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c432305d-6841-4273-b0cf-572ad0d8da95

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@mathieuartu mathieuartu changed the title chore: bump identity & notification controllers (wip) chore: bump profile-sync-controller to ^12.0.0 and notification-services-controller to ^6.0.0 Apr 15, 2025
@github-actions

github-actions Bot commented Apr 15, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8db38b0
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/22cb1306-68d1-4057-887f-130ed0dd4c2c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@mathieuartu mathieuartu added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Apr 15, 2025
@sonarqubecloud

sonarqubecloud Bot commented Apr 15, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mathieuartu mathieuartu marked this pull request as ready for review April 15, 2025 14:10
@mathieuartu mathieuartu requested a review from a team as a code owner April 15, 2025 14:10
@mathieuartu mathieuartu requested a review from a team April 15, 2025 14:10
@mathieuartu mathieuartu added this pull request to the merge queue Apr 15, 2025
Merged via the queue into main with commit 5cfc5bf Apr 15, 2025
@mathieuartu mathieuartu deleted the chore/bump-identity-notifications-controllers branch April 15, 2025 14:59
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 15, 2025
@metamaskbot metamaskbot added the release-7.46.0 Issue or pull request that will be included in release 7.46.0 label Apr 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tommasini tommasini tommasini approved these changes

@cmd-ob cmd-ob cmd-ob approved these changes

Assignees

@mathieuartu mathieuartu

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.46.0 Issue or pull request that will be included in release 7.46.0 team-identity-deprecated DEPRECATED: team no longer exists

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mathieuartu @tommasini @cmd-ob @metamaskbot