Skip to content

fix: cherry pick solana color property fix#14668

Merged
zone-live merged 1 commit into
release/7.45.0from
SOL-cherry-pick-7.45.0-text-color-fix
Apr 15, 2025
Merged

fix: cherry pick solana color property fix#14668
zone-live merged 1 commit into
release/7.45.0from
SOL-cherry-pick-7.45.0-text-color-fix

Conversation

@zone-live

@zone-live zone-live commented Apr 15, 2025

Copy link
Copy Markdown
Contributor

Description

No conflicts.

Cherry-pick commit: 4981ce8a26390ceec8b38ac58075ed136d7e21de
Original PR: #14664

Related issues

Fixes: #14657

Manual testing steps

  1. Go to this page... 2.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Description

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This PR fixes the text color in the create account input when in dark
mode.

## **Related issues**

Fixes: #14657

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

![Screenshot 2025-04-15 at 10 53
30](https://github.com/user-attachments/assets/688007c3-2bfc-4e02-b1f5-18331aebcdbe)

### **After**

![Screenshot 2025-04-15 at 10 48
24](https://github.com/user-attachments/assets/0ce51cf5-e7a3-4d4e-9725-84dcffdc1ba7)

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-networks Networks team label Apr 15, 2025
@zone-live zone-live changed the title fix: cherry pick solana color property fix (#14664) fix: cherry pick solana color property fix Apr 15, 2025
@sonarqubecloud

Copy link
Copy Markdown

@sethkfman sethkfman added Run Smoke E2E no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed and removed No E2E Smoke Needed labels Apr 15, 2025

@sethkfman sethkfman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actions Bot commented Apr 15, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: bffc2bc
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1050e060-bf4d-4ff3-85dd-e7d76e1e3fea

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sethkfman sethkfman linked an issue Apr 15, 2025 that may be closed by this pull request
@zone-live zone-live merged commit 2824770 into release/7.45.0 Apr 15, 2025
@zone-live zone-live deleted the SOL-cherry-pick-7.45.0-text-color-fix branch April 15, 2025 14:46
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed team-networks Networks team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Dark font on dark when adding account and setting the name.

3 participants