Skip to content

feat: bridge destination address picker#14656

Merged
bfullam merged 12 commits into
mainfrom
mms-1916-destination-address-picker
Apr 14, 2025
Merged

feat: bridge destination address picker#14656
bfullam merged 12 commits into
mainfrom
mms-1916-destination-address-picker

Conversation

@bfullam

@bfullam bfullam commented Apr 14, 2025

Copy link
Copy Markdown
Contributor

Description

Adds an account picker component that allows the user to select which the destination account for their bridge/swap operation.

Related issues

Fixes:

Manual testing steps

  1. Go to bridge
  2. Select any SOL asset as the destination asset
  3. See account picker

Screenshots/Recordings

Before

After

Screenshot 2025-04-14 at 17 15 53

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-identity-deprecated DEPRECATED: team no longer exists label Apr 14, 2025
@github-actions

github-actions Bot commented Apr 14, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 223a120
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/726dd190-e31a-4095-8131-cadc4e607013

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@bfullam bfullam added no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed and removed team-identity-deprecated DEPRECATED: team no longer exists labels Apr 14, 2025
@bfullam bfullam removed the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Apr 14, 2025
Comment thread app/components/UI/Bridge/components/DestinationAccountSelector.tsx/index.tsx Outdated
Comment thread app/components/UI/Bridge/components/DestinationAccountSelector.tsx/index.tsx Outdated
Comment thread app/components/UI/Bridge/components/DestinationAccountSelector.tsx/index.tsx Outdated
Comment thread app/components/UI/Bridge/index.tsx Outdated
Comment thread app/components/UI/Bridge/index.tsx Outdated
Comment thread app/components/UI/Bridge/index.tsx Outdated
@sonarqubecloud

Copy link
Copy Markdown

@bfullam bfullam marked this pull request as ready for review April 14, 2025 19:23
@bfullam bfullam requested a review from a team as a code owner April 14, 2025 19:23
@bfullam bfullam added this pull request to the merge queue Apr 14, 2025
Merged via the queue into main with commit 87d0094 Apr 14, 2025
@bfullam bfullam deleted the mms-1916-destination-address-picker branch April 14, 2025 19:42
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 14, 2025
@metamaskbot metamaskbot added the release-7.46.0 Issue or pull request that will be included in release 7.46.0 label Apr 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.46.0 Issue or pull request that will be included in release 7.46.0 team-swaps-and-bridge Swaps and Bridge team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants