Skip to content

feat: Implement insufficient balance alert into redesigned confirmations#14652

Merged
OGPoyraz merged 3 commits into
mainfrom
ogp/4664
Apr 15, 2025
Merged

feat: Implement insufficient balance alert into redesigned confirmations#14652
OGPoyraz merged 3 commits into
mainfrom
ogp/4664

Conversation

@OGPoyraz

@OGPoyraz OGPoyraz commented Apr 14, 2025

Copy link
Copy Markdown
Member

Description

This PR aims to implement insufficient balance alert into redesigned transaction confirmations.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4664

Manual testing steps

No manual steps are reproducible since staking doesn't allow to get you on to next page for now.
The recording is done by me intentionally cancelling the check in staking input view.

Screenshots/Recordings

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-04-14.at.13.28.35.mp4

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz OGPoyraz added the team-confirmations Push issues to confirmations team label Apr 14, 2025
@OGPoyraz OGPoyraz requested a review from a team as a code owner April 14, 2025 13:02
@github-actions

github-actions Bot commented Apr 14, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: f36e900
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c7acf05a-50d7-4d04-ae1b-196e43cd06c7

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@OGPoyraz OGPoyraz added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Apr 14, 2025
@github-actions

github-actions Bot commented Apr 14, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 3c2356d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9c48d547-21be-4aa8-be2f-fad8d66ddf7a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@SayaGT

SayaGT commented Apr 14, 2025

Copy link
Copy Markdown

LGTM!

@sonarqubecloud

sonarqubecloud Bot commented Apr 15, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
97.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@OGPoyraz

OGPoyraz commented Apr 15, 2025

Copy link
Copy Markdown
Member Author

I am merging this with one approval due to unblock folder structure task.

@OGPoyraz OGPoyraz added this pull request to the merge queue Apr 15, 2025
Merged via the queue into main with commit 50784b5 Apr 15, 2025
@OGPoyraz OGPoyraz deleted the ogp/4664 branch April 15, 2025 14:12
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 15, 2025
@metamaskbot metamaskbot added the release-7.46.0 Issue or pull request that will be included in release 7.46.0 label Apr 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes

Assignees

No one assigned

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.46.0 Issue or pull request that will be included in release 7.46.0 team-confirmations Push issues to confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@OGPoyraz @SayaGT @pedronfigueiredo @metamaskbot