Skip to content

fix: check for empty rpc urls#14650

Merged
bergarces merged 3 commits into
mainfrom
fix/MMASSETS-727-rpcEndpoints-check-empty
Apr 15, 2025
Merged

fix: check for empty rpc urls#14650
bergarces merged 3 commits into
mainfrom
fix/MMASSETS-727-rpcEndpoints-check-empty

Conversation

@bergarces

@bergarces bergarces commented Apr 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Some default network configurations (BTC and Solana) do not have a list of rpc endpoints. This ensures that those configurations don't cause an error when being validated, which was skipping rpc validation.

Related issues

Fixes: #14508

Manual testing steps

1 - Enable Flask build
2 - Add a new network
3 - Add a new RPC url
4 - Should validate fields correctly

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@bergarces bergarces requested a review from a team as a code owner April 14, 2025 12:44
@github-actions

github-actions Bot commented Apr 14, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@bergarces bergarces added no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed Run Smoke E2E labels Apr 14, 2025
@github-actions

github-actions Bot commented Apr 14, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 7224c90
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/24bb77fe-5581-4262-8726-01d00fb0e968

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@github-actions

github-actions Bot commented Apr 14, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 85a5d04
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0738c198-1827-4758-881d-b30d1066bf4b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud

sonarqubecloud Bot commented Apr 14, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-project-automation github-project-automation Bot moved this to Needs dev review in PR review queue Apr 14, 2025
@bergarces bergarces moved this from Needs dev review to Has approvals, needs CODEOWNER in PR review queue Apr 14, 2025
@github-project-automation github-project-automation Bot moved this from Has approvals, needs CODEOWNER to Review finalised - Ready to be merged in PR review queue Apr 15, 2025
@bergarces bergarces added this pull request to the merge queue Apr 15, 2025
Merged via the queue into main with commit 38d63b1 Apr 15, 2025
@bergarces bergarces deleted the fix/MMASSETS-727-rpcEndpoints-check-empty branch April 15, 2025 15:56
@github-project-automation github-project-automation Bot moved this from Review finalised - Ready to be merged to Merged, Closed or Archived in PR review queue Apr 15, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 15, 2025
@metamaskbot metamaskbot added the release-7.46.0 Issue or pull request that will be included in release 7.46.0 label Apr 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sahar-fehri sahar-fehri sahar-fehri approved these changes

@Prithpal-Sooriya Prithpal-Sooriya Prithpal-Sooriya approved these changes

@salimtb salimtb salimtb approved these changes

+1 more reviewer

@darkwing darkwing darkwing approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.46.0 Issue or pull request that will be included in release 7.46.0 team-assets

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read property 'some' of undefined

6 participants

@bergarces @darkwing @sahar-fehri @Prithpal-Sooriya @salimtb @metamaskbot