Skip to content

fix: pass correct disabled prop in SnapUInput#14642

Merged
hmalik88 merged 2 commits into
mainfrom
hm/fix-disabled-prop
Apr 14, 2025
Merged

fix: pass correct disabled prop in SnapUInput#14642
hmalik88 merged 2 commits into
mainfrom
hm/fix-disabled-prop

Conversation

@hmalik88

@hmalik88 hmalik88 commented Apr 13, 2025

Copy link
Copy Markdown
Contributor

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions:

  1. What is the reason for the change? The correct prop was not being passed to TextField in SnapUIInput.
  2. What is the improvement/solution? Use the correct isDisabled prop. Add test for disabled scenario.

Related issues

Fixes: #14532

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues) INVALID-PR-TEMPLATE PR's body doesn't match template labels Apr 13, 2025
@hmalik88 hmalik88 added No QA Needed Apply this label when your PR does not need any QA effort. No E2E Smoke Needed labels Apr 13, 2025
@hmalik88 hmalik88 marked this pull request as ready for review April 13, 2025 21:34
@hmalik88 hmalik88 requested a review from a team as a code owner April 13, 2025 21:34
@hmalik88 hmalik88 added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Apr 13, 2025
@sonarqubecloud

Copy link
Copy Markdown

@hmalik88 hmalik88 added this pull request to the merge queue Apr 14, 2025
Merged via the queue into main with commit b12ea88 Apr 14, 2025
@hmalik88 hmalik88 deleted the hm/fix-disabled-prop branch April 14, 2025 11:08
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 14, 2025
@metamaskbot metamaskbot added the release-7.46.0 Issue or pull request that will be included in release 7.46.0 label Apr 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template No QA Needed Apply this label when your PR does not need any QA effort. no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.46.0 Issue or pull request that will be included in release 7.46.0 team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] SnapUIInput (and possibly other inputs) isn't properly passing the disabled prop.

3 participants