test: Enable Segment/MetaMetrics for E2E tests by cmd-ob · Pull Request #14641 · MetaMask/metamask-mobile

cmd-ob · 2025-04-13T13:59:01Z

Description

Fix MetaMetrics event visibility in E2E test suite by implementing a test MetaMetrics client that routes events to a mock server. This resolves an issue that previously caused the application to hang in E2E testing mode when MetaMetrics tracking was enabled.

The solution routes MetaMetrics events to a non-existent server where they are captured by the mock server, allowing proper testing of analytics events without performance degradation.

Added example implementations demonstrating how to use metrics mocks alongside other mocks, both when using withFixtures and when starting a server within a test.

Related issues

Fixes:

Manual testing steps

Run E2E tests with MetaMetrics enabled
Verify that tests capture and validate MetaMetrics events
Confirm that the application no longer hangs during testing

Screenshots/Recordings

Before

After

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I've included tests if applicable
I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable
I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

… tracking

…ror handling in MetaMetricsTestUtils

… server

…SegmentHelper utility

…ssertEventExists method

…t tracking management

…r wallet import analytics

…ics test files

…etametrics

…ndling

…g for event tracking

…k events

…ction and return mockServer to test suite

…etrics event payloads

…r references in import wallet analytics tests

… parameter and improve filtering logic

…configuration

…ing and logging

… analytics tracking

github-actions · 2025-04-13T13:59:13Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions · 2025-04-13T14:00:36Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 2cd7cba
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4562453a-8005-4f9f-b5ab-275f9b640686

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

…ogging

christopherferreira9

LGTM, great work!

cortisiko

Left a few comments. We should have some tests for new wallet creation as well.

…ation

… creation flows

…etametrics

… into e2e/metametrics

github-actions · 2025-04-15T12:00:07Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 5b69bb5
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e8db3ca0-e6b4-4ceb-bd87-d43fc4b089f1

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

sonarqubecloud · 2025-04-15T12:02:41Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
86.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

cortisiko

✅ ✅

cmd-ob added 24 commits April 9, 2025 23:07

feat: Implement SegmentTestUtils for E2E testing and mock event tracking

39ee692

wip: Add AnalyticsHelper for event tracking and implement mock server…

44db705

… tracking

fix: Mock Segment client for E2E tests to prevent hangs and update er…

378066a

…ror handling in MetaMetricsTestUtils

refactor: Remove AnalyticsHelper and related tracking logic from mock…

568408f

… server

feat: Implement Segment tracking for wallet import analytics and add …

bd1bfc4

…SegmentHelper utility

refactor: Update import path for segment tracking and remove unused a…

95f6d4f

…ssertEventExists method

refactor: Replace SegmentHelper with SegmentTracker for improved even…

2626578

…t tracking management

refactor: Simplify E2E event tracking logic and enhance assertions fo…

941b2bc

…r wallet import analytics

refactor: Update documentation and improve type annotations in analyt…

49ebcd0

…ics test files

Merge branch 'main' of github.com:MetaMask/metamask-mobile into e2e/m…

463111a

…etametrics

feat: Add checkIfValueIsPresent method to validate presence of values

c0cea32

refactor: Update event tracking to use fetch API and improve error ha…

105a662

…ndling

wip: Add analytics tracking for wallet import and account syncing flows

a60ed08

refactor: Update MetaMetricsTestUtils to use sendMetaMetricsinE2E fla…

e7e02f8

…g for event tracking

feat: Add E2E_METAMETRICS_TRACK_URL for event tracking in tests

dd80691

feat: Integrate E2E_METAMETRICS_TRACK_URL for segment tracking in moc…

6a11b20

…k events

feat: Add support for additional launch arguments in withFixtures fun…

abc8889

…ction and return mockServer to test suite

feat: Implement getEventsPayloads function to retrieve filtered metam…

4c66075

…etrics event payloads

refactor: Remove SegmentTracker class as it is no longer needed

d7ca48e

refactor: Enhance getEventsPayloads function and remove SegmentTracke…

1487061

…r references in import wallet analytics tests

refactor: Update getEventsPayloads function to handle optional events…

9a4471a

… parameter and improve filtering logic

feat: Add smoke analytics test stages for iOS and Android in Bitrise …

44564a9

…configuration

refactor: Improve waitForPendingEndpoints function with timeout handl…

3149968

…ing and logging

feat: Implement wallet import functionality with enhanced options and…

2cd7cba

… analytics tracking

metamaskbot added the team-qa QA team label Apr 13, 2025

cmd-ob added the Run Smoke E2E label Apr 13, 2025

refactor: Simplify segment client addition and clean up API monitor l…

98b0075

…ogging

cmd-ob changed the title ~~Enhance E2E analytics tracking and event management~~ test: Enable Segment/MetaMetrics for E2E tests Apr 13, 2025

github-actions Bot removed the bitrise-result-ready label Apr 14, 2025

christopherferreira9 reviewed Apr 14, 2025

View reviewed changes

Comment thread e2e/specs/analytics/import-wallet-analytics.spec.js Outdated

christopherferreira9 reviewed Apr 14, 2025

View reviewed changes

Comment thread e2e/specs/analytics/import-wallet-analytics.spec.js Outdated

christopherferreira9 previously approved these changes Apr 14, 2025

View reviewed changes

cortisiko requested changes Apr 14, 2025

View reviewed changes

Comment thread e2e/utils/Assertions.js

Comment thread bitrise.yml Outdated

Comment thread e2e/specs/analytics/import-wallet-analytics.spec.js Outdated

refactor: remove smoke analytics tests and update assertions document…

04c8d00

…ation

cmd-ob dismissed christopherferreira9’s stale review via 04c8d00 April 15, 2025 08:07

cmd-ob requested review from christopherferreira9 and cortisiko and removed request for NicolasMassart April 15, 2025 08:07

cmd-ob added 4 commits April 15, 2025 09:08

Merge branch 'main' into e2e/metametrics

8b09865

feat(analytics): add onboarding analytics tests for wallet import and…

d0c3861

… creation flows

Merge branch 'main' of github.com:MetaMask/metamask-mobile into e2e/m…

fdb58b5

…etametrics

Merge branch 'e2e/metametrics' of github.com:MetaMask/metamask-mobile…

5b69bb5

… into e2e/metametrics

mirceanis approved these changes Apr 15, 2025

View reviewed changes

cmd-ob added Run Smoke E2E and removed Run Smoke E2E labels Apr 15, 2025

Prithpal-Sooriya approved these changes Apr 15, 2025

View reviewed changes

metamaskbot added the bitrise-result-ready label Apr 15, 2025

github-actions Bot removed the bitrise-result-ready label Apr 15, 2025

cortisiko approved these changes Apr 15, 2025

View reviewed changes

cmd-ob enabled auto-merge April 15, 2025 14:59

cmd-ob added this pull request to the merge queue Apr 15, 2025

Merged via the queue into main with commit 99327ee Apr 15, 2025

cmd-ob deleted the e2e/metametrics branch April 15, 2025 15:22

github-actions Bot locked and limited conversation to collaborators Apr 15, 2025

metamaskbot added the release-7.46.0 Issue or pull request that will be included in release 7.46.0 label Apr 15, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test: Enable Segment/MetaMetrics for E2E tests#14641

test: Enable Segment/MetaMetrics for E2E tests#14641
cmd-ob merged 42 commits into
mainfrom
e2e/metametrics

cmd-ob commented Apr 13, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 13, 2025

Uh oh!

github-actions Bot commented Apr 13, 2025 •

edited by metamaskbot

Loading

Uh oh!

Uh oh!

Uh oh!

christopherferreira9 left a comment

Uh oh!

cortisiko left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 15, 2025 •

edited by metamaskbot

Loading

Uh oh!

sonarqubecloud Bot commented Apr 15, 2025

Uh oh!

cortisiko left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

cmd-ob commented Apr 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions Bot commented Apr 13, 2025

Uh oh!

github-actions Bot commented Apr 13, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

Uh oh!

Uh oh!

christopherferreira9 left a comment

Choose a reason for hiding this comment

Uh oh!

cortisiko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 15, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

sonarqubecloud Bot commented Apr 15, 2025

Quality Gate passed

Uh oh!

cortisiko left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

cmd-ob commented Apr 13, 2025 •

edited

Loading

github-actions Bot commented Apr 13, 2025 •

edited by metamaskbot

Loading

github-actions Bot commented Apr 15, 2025 •

edited by metamaskbot

Loading