Skip to content

fix: Fix/deploy bitrise ipa path#14639

Merged
Cal-L merged 2 commits into
mainfrom
fix/deploy-bitrise-ipa-path
Apr 12, 2025
Merged

fix: Fix/deploy bitrise ipa path#14639
Cal-L merged 2 commits into
mainfrom
fix/deploy-bitrise-ipa-path

Conversation

@Cal-L

@Cal-L Cal-L commented Apr 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR preserves the pipeline variable for the IPA when releasing iOS to store

Related issues

Fixes:

Manual testing steps

  • Run release_ios_to_store_pipeline against this branch
  • IPA should be deployed to store

Screenshots/Recordings

Before

After

https://app.bitrise.io/build/4c052bb6-8b38-4a84-a845-017629ed549a

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Cal-L Cal-L requested a review from a team April 11, 2025 23:59
@github-actions

github-actions Bot commented Apr 11, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L force-pushed the fix/deploy-bitrise-ipa-path branch from 944eaba to ccb193f Compare April 12, 2025 00:00
@Cal-L Cal-L added No QA Needed Apply this label when your PR does not need any QA effort. No E2E Smoke Needed team-mobile-platform Mobile Platform team no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed labels Apr 12, 2025
@sonarqubecloud

sonarqubecloud Bot commented Apr 12, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Cal-L Cal-L added this pull request to the merge queue Apr 12, 2025
Merged via the queue into main with commit b8f23e3 Apr 12, 2025
@Cal-L Cal-L deleted the fix/deploy-bitrise-ipa-path branch April 12, 2025 02:32
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 12, 2025
@metamaskbot metamaskbot added the release-7.46.0 Issue or pull request that will be included in release 7.46.0 label Apr 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tommasini tommasini tommasini approved these changes

Assignees

No one assigned

Labels

No QA Needed Apply this label when your PR does not need any QA effort. no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.46.0 Issue or pull request that will be included in release 7.46.0 team-mobile-platform Mobile Platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Cal-L @tommasini @gauthierpetetin @metamaskbot