Skip to content

fix(ramp,test): switch network assertion#14624

Merged
georgeweiler merged 3 commits into
mainfrom
fix/ramp-e2e-network-switch-test
Apr 12, 2025
Merged

fix(ramp,test): switch network assertion#14624
georgeweiler merged 3 commits into
mainfrom
fix/ramp-e2e-network-switch-test

Conversation

@wachunei

@wachunei wachunei commented Apr 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Description

This PR removes an assertion that depends on 3rd party availability of tokens. The test keeps the expected assertion of a network change.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added the team-money-movement issues related to Money Movement features label Apr 11, 2025
@github-actions

github-actions Bot commented Apr 11, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: eb47b98
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7510944b-b2bf-4bfa-b841-fa3605bd6539

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@wachunei wachunei added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Apr 11, 2025
@github-actions

github-actions Bot commented Apr 11, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: ccc3c7a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/471bcbaa-2a04-4fef-bc67-98fa48714fe9

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@wachunei wachunei mentioned this pull request Apr 11, 2025
Closed
2 tasks
@C-Ivan C-Ivan self-requested a review April 11, 2025 21:18
C-Ivan
C-Ivan approved these changes Apr 11, 2025
View reviewed changes

@C-Ivan C-Ivan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@georgeweiler georgeweiler marked this pull request as ready for review April 11, 2025 23:09
@github-actions

github-actions Bot commented Apr 11, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter

codecov-commenter commented Apr 11, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.28%. Comparing base (08382bc) to head (31683df).
Report is 43 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #14624      +/-   ##
==========================================
+ Coverage   66.57%   67.28%   +0.70%     
==========================================
  Files        2257     2275      +18     
  Lines       48273    48875     +602     
  Branches     6823     6974     +151     
==========================================
+ Hits        32139    32884     +745     
+ Misses      14102    13921     -181     
- Partials     2032     2070      +38

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud

sonarqubecloud Bot commented Apr 11, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@georgeweiler georgeweiler added this pull request to the merge queue Apr 11, 2025
Merged via the queue into main with commit 720e4bc Apr 12, 2025
@georgeweiler georgeweiler deleted the fix/ramp-e2e-network-switch-test branch April 12, 2025 00:07
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 12, 2025
@metamaskbot metamaskbot added the release-7.46.0 Issue or pull request that will be included in release 7.46.0 label Apr 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@C-Ivan C-Ivan C-Ivan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.46.0 Issue or pull request that will be included in release 7.46.0 team-money-movement issues related to Money Movement features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wachunei @codecov-commenter @C-Ivan @georgeweiler @metamaskbot