Skip to content

fix: Re-introduce bitrise ipa path#14619

Merged
Cal-L merged 1 commit into
mainfrom
fix/deploy-bitrise-ipa-path
Apr 11, 2025
Merged

fix: Re-introduce bitrise ipa path#14619
Cal-L merged 1 commit into
mainfrom
fix/deploy-bitrise-ipa-path

Conversation

@Cal-L

@Cal-L Cal-L commented Apr 11, 2025

Copy link
Copy Markdown
Contributor

Description

This PR fixes the failing deploy to ios step on Bitrise by reintroducing a missing bitrise ipa deploy path. It was accidentally removed here - https://github.com/MetaMask/metamask-mobile/pull/14569/files#diff-61d1ee831cb1df242161a7d23171914a1d5d628c7659b52db957d80a9394bd68R1842

Related issues

Fixes: https://consensys.slack.com/archives/C02U025CVU4/p1744387408743859

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Cal-L Cal-L requested a review from a team April 11, 2025 19:00
@Cal-L Cal-L added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Apr 11, 2025
@github-project-automation github-project-automation Bot moved this to Needs dev review in PR review queue Apr 11, 2025
@Cal-L Cal-L added the team-mobile-platform Mobile Platform team label Apr 11, 2025
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L added No E2E Smoke Needed no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed labels Apr 11, 2025
@Cal-L Cal-L enabled auto-merge April 11, 2025 19:02

@sethkfman sethkfman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation Bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Apr 11, 2025
@sonarqubecloud

Copy link
Copy Markdown

@Cal-L Cal-L added this pull request to the merge queue Apr 11, 2025
Merged via the queue into main with commit ef7f0ed Apr 11, 2025
@Cal-L Cal-L deleted the fix/deploy-bitrise-ipa-path branch April 11, 2025 19:38
@github-project-automation github-project-automation Bot moved this from Review finalised - Ready to be merged to Merged, Closed or Archived in PR review queue Apr 11, 2025
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 11, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 11, 2025
@metamaskbot metamaskbot added the release-7.46.0 Issue or pull request that will be included in release 7.46.0 label Apr 11, 2025
@Cal-L Cal-L restored the fix/deploy-bitrise-ipa-path branch April 11, 2025 22:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

No QA Needed Apply this label when your PR does not need any QA effort. no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.46.0 Issue or pull request that will be included in release 7.46.0 team-mobile-platform Mobile Platform team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants