Skip to content

chore: updates the auto-detected NFT check#14608

Merged
christopherferreira9 merged 1 commit into
mainfrom
christopher/fix-assets-nft-detection-e2e
Apr 11, 2025
Merged

chore: updates the auto-detected NFT check#14608
christopherferreira9 merged 1 commit into
mainfrom
christopher/fix-assets-nft-detection-e2e

Conversation

@christopherferreira9

@christopherferreira9 christopherferreira9 commented Apr 11, 2025 •
edited by Unik0rnMaggie
Loading

Copy link
Copy Markdown
Contributor

Description

Updates the check for the auto detected NFT.

Related issues

Fixes: #14609

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

github-actions Bot commented Apr 11, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Apr 11, 2025
@github-actions

github-actions Bot commented Apr 11, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 6261d05
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/10d28b16-3b2a-4d5c-9e9f-c59b09d105e4

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud

sonarqubecloud Bot commented Apr 11, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@christopherferreira9 christopherferreira9 added this pull request to the merge queue Apr 11, 2025
Merged via the queue into main with commit c06f28f Apr 11, 2025
@christopherferreira9 christopherferreira9 deleted the christopher/fix-assets-nft-detection-e2e branch April 11, 2025 14:41
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 11, 2025
@metamaskbot metamaskbot added the release-7.46.0 Issue or pull request that will be included in release 7.46.0 label Apr 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@NicolasMassart NicolasMassart NicolasMassart approved these changes

@sahar-fehri sahar-fehri sahar-fehri approved these changes

@salimtb salimtb salimtb approved these changes

Assignees

No one assigned

Labels

release-7.46.0 Issue or pull request that will be included in release 7.46.0 team-qa QA team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Android Specific: failure on main branch for smoke e2e assets test

5 participants

@christopherferreira9 @NicolasMassart @sahar-fehri @salimtb @metamaskbot