fix: Add delay in checkPermissions for iOS to prevent UI crash#14602
Merged
Conversation
This update introduces a delay in the checkPermissions function specifically for iOS to address a race condition that causes a UI crash when the approvalPromise is resolved. The delay helps ensure smoother handling of permission requests and improves overall stability.
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
7 tasks
This update adds platform-specific mocks for the checkPermissions tests, ensuring consistent behavior across iOS and Android. It introduces a delay for iOS after permission approval to prevent UI crashes and verifies that no delay occurs on Android. The tests are structured to validate these behaviors effectively.
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a UI crash on iOS in
AccountConnect.tsxcaused by a race condition inpermissionsController.getPermissions().await wait(100)incheckPermissionsfor iOS to resolve the race condition.Debugging Notes
This issue was tricky to debug as it occurred more frequently in live DEV environments. Eventually, I tracked it down by launching the app via Xcode instead of the regular React Native CLI, which provided access to all native logs and revealed the race condition.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist