Skip to content

ci: address lockfile issue with detox#14600

Merged
cortisiko merged 2 commits into
mainfrom
ci/address-lockfile-issue-on-detox
Apr 10, 2025
Merged

ci: address lockfile issue with detox#14600
cortisiko merged 2 commits into
mainfrom
ci/address-lockfile-issue-on-detox

Conversation

@cortisiko

Copy link
Copy Markdown
Member

Description

There is an existing detox issue where the tests would fail with the following error:


Error: Unable to update lock within the stale threshold
    at /Users/vagrant/git/node_modules/proper-lockfile/lib/lockfile.js:[REDACTED]09:2[REDACTED]
    at newFs.<computed> [as utimes] (/Users/vagrant/git/node_modules/proper-lockfile/lib/adapter.js:20:[REDACTED]3)
    at Timeout._onTimeout (/Users/vagrant/git/node_modules/proper-lockfile/lib/lockfile.js:[REDACTED]00:20)
    at listOnTimeout (node:internal/timers:58[REDACTED]:[REDACTED]7)
    at process.processTimers (node:internal/timers:5[REDACTED]9:7) {
  code: 'ECOMPROMISED'
}

The issue is stemming from Detox itself and was reported here. Unfortunately there is no fix available. One of the commenters suggested booting the simulator prior to running the test rather than letting Detox handle it during test execution.

The purpose of this PR is to add a bitrise step in the ios_e2e_test workflow that boots the simulator before executing the tests.

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMQA-411

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cortisiko cortisiko requested a review from a team April 10, 2025 21:56
@metamaskbot metamaskbot added the team-qa QA team label Apr 10, 2025
@github-actions

github-actions Bot commented Apr 10, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: fd9f60e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3b30bc71-cc3b-4cd5-bedb-8af530e3d821

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud

Copy link
Copy Markdown

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. You can apply the no change log label

@davibroc davibroc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cortisiko cortisiko added this pull request to the merge queue Apr 10, 2025
@cortisiko cortisiko added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Apr 10, 2025
Merged via the queue into main with commit 21ee35e Apr 10, 2025
@cortisiko cortisiko deleted the ci/address-lockfile-issue-on-detox branch April 10, 2025 23:17
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 10, 2025
@metamaskbot metamaskbot added the release-7.46.0 Issue or pull request that will be included in release 7.46.0 label Apr 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.46.0 Issue or pull request that will be included in release 7.46.0 team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants