fix: cp-7.44.0 Correct SnapUIImage border radius and sizing logic#14578
Merged
Conversation
Contributor
|
david0xd
approved these changes
Apr 11, 2025
|
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a container for the SnapUIImage component and apply the border radius directly to that hiding the overflow. Additionally adds logic to deal with
viewBoxand other problems that would prevent SVGs from rendering or overflow outside of the container with border radius.Related issues
Fixes: MetaMask/snaps#3243
Fixes #14288
Screenshots/Recordings