Skip to content

feat: Add AddressInput component#14571

Merged
hmalik88 merged 12 commits into
mainfrom
hm/address-input
Apr 15, 2025
Merged

feat: Add AddressInput component#14571
hmalik88 merged 12 commits into
mainfrom
hm/address-input

Conversation

@hmalik88

@hmalik88 hmalik88 commented Apr 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions:

  1. What is the reason for the change? Porting AddressInput component from the extension.

Related issues

Fixes: #14329

Manual testing steps

  1. Pull down the branch and run in the simulator
  2. Navigate to the test-snaps page and trigger the custom UI from the send flow snap
  3. Observe the results.

Screenshots/Recordings

After

Normal scenario

Screen.Recording.2025-04-14.at.10.26.53.PM.mov

Matched, Disabled & Error

Screen.Recording.2025-04-14.at.10.14.59.PM.mov

Matched, Disabled

Screen.Recording.2025-04-14.at.10.16.24.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

github-actions Bot commented Apr 9, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

FrederikBolding
FrederikBolding reviewed Apr 10, 2025
View reviewed changes
Comment thread app/components/Snaps/SnapUIAddressInput/SnapUIAddressInput.test.tsx Outdated
FrederikBolding
FrederikBolding reviewed Apr 10, 2025
View reviewed changes
Comment thread app/components/Snaps/SnapUIAddressInput/SnapUIAddressInput.test.tsx
FrederikBolding
FrederikBolding reviewed Apr 10, 2025
View reviewed changes
Comment thread app/components/Snaps/SnapUIAddressInput/SnapUIAddressInput.tsx Outdated
FrederikBolding
FrederikBolding reviewed Apr 10, 2025
View reviewed changes
Comment thread app/components/Snaps/SnapUIAddressInput/SnapUIAddressInput.tsx Outdated
@hmalik88 hmalik88 added No E2E Smoke Needed mobile-snaps team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues) and removed No E2E Smoke Needed labels Apr 12, 2025
@github-actions

github-actions Bot commented Apr 12, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 3c1f6dc
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b8a82a80-1f4c-4a4f-a34b-84d87f5f9191

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@codecov-commenter

codecov-commenter commented Apr 12, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 68.42105% with 12 lines in your changes missing coverage. Please review.

Project coverage is 67.28%. Comparing base (08382bc) to head (3c1f6dc).
Report is 46 commits behind head on main.

Files with missing lines Patch % Lines
...ts/Snaps/SnapUIAddressInput/SnapUIAddressInput.tsx 73.52% 6 Missing and 3 partials ⚠️
...omponents/Snaps/SnapUIRenderer/components/field.ts 0.00% 2 Missing ⚠️
...s/Snaps/SnapUIRenderer/components/address-input.ts 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #14571      +/-   ##
==========================================
+ Coverage   66.57%   67.28%   +0.71%     
==========================================
  Files        2257     2281      +24     
  Lines       48273    48928     +655     
  Branches     6823     6991     +168     
==========================================
+ Hits        32139    32923     +784     
+ Misses      14102    13932     -170     
- Partials     2032     2073      +41

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hmalik88 hmalik88 added the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label Apr 12, 2025
@hmalik88 hmalik88 marked this pull request as ready for review April 12, 2025 17:36
@hmalik88 hmalik88 requested review from a team as code owners April 12, 2025 17:36
@hmalik88 hmalik88 added Run Smoke E2E no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. No QA Needed Apply this label when your PR does not need any QA effort. and removed Run Smoke E2E skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. labels Apr 12, 2025
@hmalik88 hmalik88 removed the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label Apr 12, 2025
@sonarqubecloud

sonarqubecloud Bot commented Apr 15, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@hmalik88 hmalik88 added this pull request to the merge queue Apr 15, 2025
Merged via the queue into main with commit 3a22704 Apr 15, 2025
@hmalik88 hmalik88 deleted the hm/address-input branch April 15, 2025 22:40
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 15, 2025
@metamaskbot metamaskbot added the release-7.46.0 Issue or pull request that will be included in release 7.46.0 label Apr 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@FrederikBolding FrederikBolding FrederikBolding left review comments

@david0xd david0xd david0xd approved these changes

Assignees

No one assigned

Labels

mobile-snaps No QA Needed Apply this label when your PR does not need any QA effort. no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.46.0 Issue or pull request that will be included in release 7.46.0 team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

port Snaps AddressInput component to mobile

5 participants

@hmalik88 @codecov-commenter @FrederikBolding @david0xd @metamaskbot