Skip to content

feat(multi-srp): enable multi-srp in main and beta#14558

Merged
shane-t merged 11 commits into
mainfrom
enable-multi-srp
Apr 15, 2025
Merged

feat(multi-srp): enable multi-srp in main and beta#14558
shane-t merged 11 commits into
mainfrom
enable-multi-srp

Conversation

@shane-t

@shane-t shane-t commented Apr 9, 2025

Copy link
Copy Markdown
Member

Description

Enable Multi-SRP

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@shane-t shane-t requested a review from a team April 9, 2025 13:20
@shane-t shane-t requested a review from a team as a code owner April 9, 2025 13:20
@metamaskbot metamaskbot added the team-identity-deprecated DEPRECATED: team no longer exists label Apr 9, 2025
tommasini
tommasini previously approved these changes Apr 9, 2025
View reviewed changes
@github-actions

github-actions Bot commented Apr 9, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 4b04019
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c175df11-9975-4f36-90a4-d47f4701013a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@github-actions

github-actions Bot commented Apr 10, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: bd31a49
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f887cec9-eb4a-4e8b-9757-e1355d34508a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@github-actions

github-actions Bot commented Apr 10, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions

github-actions Bot commented Apr 10, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 2d68ad2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7dda2911-6166-4889-882e-fae9eb058287

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@github-actions

github-actions Bot commented Apr 11, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 3b51c46
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c563027f-ee3b-4806-a35d-9d11620aba78

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@github-actions

github-actions Bot commented Apr 11, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 676ee8c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/28d0d534-3cb6-4a6e-8b37-3b72e86141d9

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@shane-t shane-t changed the title chore: enable multi-srp in main and beta cp(12.17.0): enable multi-srp in main and beta Apr 14, 2025
@shane-t shane-t changed the title cp(12.17.0): enable multi-srp in main and beta chore: enable multi-srp in main and beta Apr 14, 2025
@github-actions

github-actions Bot commented Apr 14, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: aeaf25a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fd607dd0-5b80-429f-8b68-0201f9072c7f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@github-actions

github-actions Bot commented Apr 15, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: c423673
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f1c2d953-8707-435d-bbe4-9c99e77394f5

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@shane-t shane-t changed the title chore: enable multi-srp in main and beta feat(multi-srp): enable multi-srp in main and beta Apr 15, 2025
@codecov-commenter

codecov-commenter commented Apr 15, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.33%. Comparing base (87d0094) to head (a9b4e5f).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #14558      +/-   ##
==========================================
- Coverage   67.34%   67.33%   -0.01%     
==========================================
  Files        2284     2284              
  Lines       49012    49012              
  Branches     7016     7016              
==========================================
- Hits        33005    33003       -2     
- Misses      13922    13924       +2     
  Partials     2085     2085

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud

sonarqubecloud Bot commented Apr 15, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@shane-t shane-t added this pull request to the merge queue Apr 15, 2025
Merged via the queue into main with commit 10c29f8 Apr 15, 2025
@shane-t shane-t deleted the enable-multi-srp branch April 15, 2025 13:25
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 15, 2025
@metamaskbot metamaskbot added the release-7.46.0 Issue or pull request that will be included in release 7.46.0 label Apr 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tommasini tommasini tommasini approved these changes

Assignees

No one assigned

Labels

release-7.46.0 Issue or pull request that will be included in release 7.46.0 team-identity-deprecated DEPRECATED: team no longer exists

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@shane-t @codecov-commenter @tommasini @metamaskbot @montelaidev @Andepande