Skip to content

cherry-pick 70ddf46 (#14383)#14547

Merged
NicolasMassart merged 1 commit into
release/7.44.0from
cherry-pick-70ddf46
Apr 9, 2025
Merged

cherry-pick 70ddf46 (#14383)#14547
NicolasMassart merged 1 commit into
release/7.44.0from
cherry-pick-70ddf46

Conversation

@NicolasMassart

Copy link
Copy Markdown
Contributor

manual cherry-pick 70ddf46 for PR #14383
Conflicts fixed

Changed expected text of a token due to a change.

Fixes:

1. Go to this page...
2.
3.

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

<!-- [screenshots/recordings] -->

<!-- [screenshots/recordings] -->

- [ ✓ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ✓ ] I've completed the PR template to the best of my ability
- [ ✓ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ✓ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@NicolasMassart NicolasMassart requested a review from a team as a code owner April 9, 2025 09:53
@github-actions

github-actions Bot commented Apr 9, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label Apr 9, 2025
@NicolasMassart NicolasMassart enabled auto-merge (squash) April 9, 2025 09:54
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Apr 9, 2025
@sonarqubecloud

sonarqubecloud Bot commented Apr 9, 2025

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Apr 9, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 766fbd8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ce582dc1-a7a9-441f-9522-1a8d0f6975e0

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@NicolasMassart NicolasMassart changed the title cherry-pick 70ddf46 cherry-pick 70ddf46 (#14383) Apr 9, 2025
@NicolasMassart NicolasMassart merged commit 6dab3a0 into release/7.44.0 Apr 9, 2025
@NicolasMassart NicolasMassart deleted the cherry-pick-70ddf46 branch April 9, 2025 10:29
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template team-mobile-platform Mobile Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants