chore(runway): cherry-pick STAKE-1005 refresh staking data when staking txs are confirmed (#14520)#14541
Merged
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
This comment was marked as outdated.
This comment was marked as outdated.
|
NicolasMassart
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix missing pooled-staking data refreshing when a
transaction is confirmed using the redesigned confirmation screens.
Changes:
@metamask/earn-controllerdependency to^11.0.0refreshPooledStakesin transactionsubscription handlers
TransactionController:transactionConfirmedevent toEarnControllermessengersRelated issues
Fixes:
Manual testing steps
Prerequisite:
.js.envfile to include the following variablesTo test the unstaking flow, we must first stake some ETH. You can skip
this part if you have Staked Ethereum already.
From the token list home screen, click on Ethereum or Staked Ethereum
On the Ethereum token details screen, click "stake" or "stake more"
Stake a valid amount of ETH and continue to the confirmation screen
Review and confirm your stake
To unstake, click on Ethereum or Staked Ethereum from the token list
screen
Click "unstake" (only visible if you have Staked ETH already)
Enter a valid amount to unstake and continue to the confirmation
screen
Review and confirm your unstake transaction
Wait for smart transaction success
After your transaction is confirmed, return to the Ethereum token
details screen and you should see a new blue unstaking banner.
Screenshots/Recordings
stake-1005-refresh-staking-data-when-staking-txs-are-confirmed-with-redesigned-confirmation-screens.mov
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots. db7e9e0