Skip to content

fix: cp-7.44.0 Add notification when redesigned transaction confirmation submitted and finalized#14495

Merged
OGPoyraz merged 9 commits intomainfrom
ogp/14438
Apr 8, 2025
Merged

fix: cp-7.44.0 Add notification when redesigned transaction confirmation submitted and finalized#14495
OGPoyraz merged 9 commits intomainfrom
ogp/14438

Conversation

@OGPoyraz
Copy link
Copy Markdown
Member

@OGPoyraz OGPoyraz commented Apr 8, 2025

Description

Adds an event handler to TransactionController:transactionApproved and when transaction approved it calls NotificationManager to handle notification.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4595

Manual testing steps

No user flow changes

Screenshots/Recordings

Fixes : #14438

Before

After

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-04-08.at.07.38.33.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz OGPoyraz requested a review from a team as a code owner April 8, 2025 05:49
@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Apr 8, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 9d2dd71
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/45b019a8-62fc-42d0-ac64-135660834276

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
97.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@OGPoyraz OGPoyraz added this pull request to the merge queue Apr 8, 2025
Merged via the queue into main with commit 7744ef4 Apr 8, 2025
41 of 42 checks passed
@OGPoyraz OGPoyraz deleted the ogp/14438 branch April 8, 2025 09:21
@metamaskbot metamaskbot added the release-7.45.0 Issue or pull request that will be included in release 7.45.0 label Apr 8, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes

@vinistevam vinistevam vinistevam approved these changes

Assignees

No one assigned

Labels

release-7.45.0 Issue or pull request that will be included in release 7.45.0 team-confirmations Push issues to confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Staking transaction confirmation toast missing

4 participants

@OGPoyraz @pedronfigueiredo @vinistevam @metamaskbot