Skip to content

fix: bridge hide staked assets from token lists#14457

Merged
infiniteflower merged 2 commits into
mainfrom
mms-2165-bridge-hide-staked-native-assets
Apr 11, 2025
Merged

fix: bridge hide staked assets from token lists#14457
infiniteflower merged 2 commits into
mainfrom
mms-2165-bridge-hide-staked-native-assets

Conversation

@infiniteflower

@infiniteflower infiniteflower commented Apr 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR fixes an issue where staked native assets would show up in the bridge token selectors.

Related issues

Fixes:

Manual testing steps

  1. Go to Bridge
  2. Open up source token picker
  3. Observe that no staked tokens appear in the list

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@infiniteflower infiniteflower changed the base branch from main to mms-1912-bridge-solana-assets April 4, 2025 22:37
@github-actions

github-actions Bot commented Apr 4, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-swaps-and-bridge Swaps and Bridge team label Apr 4, 2025
@infiniteflower infiniteflower changed the title Mms 2165 bridge hide staked native assets fix (bridge): hide staked assets from token lists Apr 4, 2025
@infiniteflower infiniteflower changed the title fix (bridge): hide staked assets from token lists fix: bridge hide staked assets from token lists Apr 4, 2025
@infiniteflower infiniteflower force-pushed the mms-1912-bridge-solana-assets branch from 330e61a to 6ef8201 Compare April 7, 2025 14:59
@infiniteflower infiniteflower force-pushed the mms-2165-bridge-hide-staked-native-assets branch from d477577 to 324eb86 Compare April 7, 2025 15:00
@infiniteflower infiniteflower force-pushed the mms-1912-bridge-solana-assets branch from 6ef8201 to bf6e992 Compare April 7, 2025 19:27
@infiniteflower infiniteflower force-pushed the mms-2165-bridge-hide-staked-native-assets branch from 324eb86 to 4359a18 Compare April 7, 2025 19:28
micaelae
micaelae previously approved these changes Apr 8, 2025
View reviewed changes
@infiniteflower infiniteflower force-pushed the mms-1912-bridge-solana-assets branch 2 times, most recently from aa40f74 to 1a79ab4 Compare April 10, 2025 20:13
Base automatically changed from mms-1912-bridge-solana-assets to main April 10, 2025 21:12
@infiniteflower infiniteflower dismissed micaelae’s stale review April 10, 2025 21:12

The base branch was changed.

@infiniteflower infiniteflower force-pushed the mms-2165-bridge-hide-staked-native-assets branch from 4359a18 to 18cfdcb Compare April 11, 2025 17:10
@infiniteflower infiniteflower marked this pull request as ready for review April 11, 2025 17:11
@infiniteflower infiniteflower requested a review from a team as a code owner April 11, 2025 17:11
@infiniteflower infiniteflower requested a review from micaelae April 11, 2025 17:13
@github-actions

github-actions Bot commented Apr 11, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 18cfdcb
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b723a0f6-3492-4868-8c2d-e6bac9e3c13e

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

micaelae
micaelae previously approved these changes Apr 11, 2025
View reviewed changes
@github-actions

github-actions Bot commented Apr 11, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: c37d7ff
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/893cedd8-ac7d-47e3-9ee7-6e8024fa1ea5

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud

sonarqubecloud Bot commented Apr 11, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@infiniteflower infiniteflower added this pull request to the merge queue Apr 11, 2025
Merged via the queue into main with commit 8a4dc71 Apr 11, 2025
@infiniteflower infiniteflower deleted the mms-2165-bridge-hide-staked-native-assets branch April 11, 2025 20:13
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 11, 2025
@metamaskbot metamaskbot added the release-7.46.0 Issue or pull request that will be included in release 7.46.0 label Apr 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@micaelae micaelae micaelae approved these changes

Assignees

No one assigned

Labels

release-7.46.0 Issue or pull request that will be included in release 7.46.0 team-swaps-and-bridge Swaps and Bridge team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@infiniteflower @micaelae @metamaskbot