fix: 3273 keyboard blocks send flow (Solana)#14403
Merged
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
FrederikBolding
previously approved these changes
Apr 4, 2025
FrederikBolding
approved these changes
Apr 4, 2025
|
matthewwalsh0
approved these changes
Apr 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
In the Solana swap flow, when the user opens the native keyboard on the device, the inputs are hidden behind the popup keyboard.
Also addressed the issue where the modal is rendered at a fixed height and now will render to the content size if no size prop is provided.
Related issues
Fixes: MetaMask/snaps#3273
Fixes #14287
Manual testing steps
Screenshots/Recordings
Before
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-03-27.at.16.17.23.mp4
After
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-04-03.at.15.55.01.mp4
Pre-merge author checklist
Pre-merge reviewer checklist