Skip to content

fix: 3273 keyboard blocks send flow (Solana)#14403

Merged
FrederikBolding merged 13 commits into
mainfrom
3273-keyboard-blocks-send-flow
Apr 4, 2025
Merged

fix: 3273 keyboard blocks send flow (Solana)#14403
FrederikBolding merged 13 commits into
mainfrom
3273-keyboard-blocks-send-flow

Conversation

@Daniel-Cross

@Daniel-Cross Daniel-Cross commented Apr 3, 2025

Copy link
Copy Markdown
Contributor

Description

In the Solana swap flow, when the user opens the native keyboard on the device, the inputs are hidden behind the popup keyboard.

Also addressed the issue where the modal is rendered at a fixed height and now will render to the content size if no size prop is provided.

Related issues

Fixes: MetaMask/snaps#3273
Fixes #14287

Manual testing steps

  1. Add a Solana account
  2. Open swap flow and paste in valid wallet address
  3. See that device/simulator keyboard does not block the amount and address inputs

Screenshots/Recordings

Before

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-03-27.at.16.17.23.mp4

After

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-04-03.at.15.55.01.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Daniel-Cross Daniel-Cross added No QA Needed Apply this label when your PR does not need any QA effort. No E2E Smoke Needed team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues) labels Apr 3, 2025
@Daniel-Cross Daniel-Cross self-assigned this Apr 3, 2025
@Daniel-Cross Daniel-Cross requested review from a team as code owners April 3, 2025 13:57
@Daniel-Cross Daniel-Cross linked an issue Apr 3, 2025 that may be closed by this pull request
@github-actions

github-actions Bot commented Apr 3, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label Apr 3, 2025
Comment thread ios/MetaMask.xcodeproj/project.pbxproj Outdated
Comment thread app/components/Snaps/SnapDialogApproval/SnapDialogApproval.tsx
Comment thread ios/MetaMask.xcodeproj/project.pbxproj Outdated
Comment thread app/components/Snaps/SnapDialogApproval/SnapDialogApproval.tsx
FrederikBolding
FrederikBolding previously approved these changes Apr 4, 2025
@sonarqubecloud

sonarqubecloud Bot commented Apr 4, 2025

Copy link
Copy Markdown

@FrederikBolding FrederikBolding added this pull request to the merge queue Apr 4, 2025
Merged via the queue into main with commit 5f4c491 Apr 4, 2025
@FrederikBolding FrederikBolding deleted the 3273-keyboard-blocks-send-flow branch April 4, 2025 11:22
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 4, 2025
@metamaskbot metamaskbot added the release-7.45.0 Issue or pull request that will be included in release 7.45.0 label Apr 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.45.0 Issue or pull request that will be included in release 7.45.0 team-mobile-platform Mobile Platform team team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: On iOS devices, the device's keyboard overlays the Send modal Keyboard blocks send flow

5 participants