Skip to content

feat: bridge solana assets#14365

Merged
infiniteflower merged 43 commits into
mainfrom
mms-1912-bridge-solana-assets
Apr 10, 2025
Merged

feat: bridge solana assets#14365
infiniteflower merged 43 commits into
mainfrom
mms-1912-bridge-solana-assets

Conversation

@infiniteflower

@infiniteflower infiniteflower commented Apr 2, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR adds Solana assets, balances, and top tokens to the source and destination token pickers for Bridge.

Related issues

Fixes:

Manual testing steps

  1. Add the following to .js.env
export MM_BRIDGE_UI_ENABLED="true"
export PORTFOLIO_VIEW="true"
export METAMASK_BUILD_TYPE="flask"
  1. Make a Solana account
  2. Click on wallet actions
  3. Observe Bridge button and click on it to go to Bridge
  4. Click on source token
  5. Observe that Solana assets are listed

Screenshots/Recordings

Before

After

Screen.Recording.2025-04-10.at.2.20.12.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

github-actions Bot commented Apr 2, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-swaps-and-bridge Swaps and Bridge team label Apr 2, 2025
@infiniteflower infiniteflower marked this pull request as ready for review April 3, 2025 21:00
@infiniteflower infiniteflower requested review from a team as code owners April 3, 2025 21:00
@infiniteflower infiniteflower force-pushed the feat/bridge-solana-button branch from fd6e0c4 to 00056f7 Compare April 4, 2025 01:23
@infiniteflower infiniteflower requested a review from a team April 4, 2025 01:23
@infiniteflower infiniteflower force-pushed the mms-1912-bridge-solana-assets branch from 266b8d0 to 0e16fb3 Compare April 4, 2025 01:28
@infiniteflower infiniteflower changed the title WIP first commit for bridge solana assets feat: bridge solana assets Apr 4, 2025
@infiniteflower infiniteflower mentioned this pull request Apr 4, 2025
Merged
7 tasks
@infiniteflower infiniteflower force-pushed the feat/bridge-solana-button branch from 364cdad to 45af531 Compare April 4, 2025 17:48
@infiniteflower infiniteflower force-pushed the mms-1912-bridge-solana-assets branch from 0e16fb3 to c6701ce Compare April 4, 2025 17:50
@infiniteflower infiniteflower requested a review from a team as a April 4, 2025 21:52
@infiniteflower infiniteflower force-pushed the mms-1912-bridge-solana-assets branch from 03ea839 to 330e61a Compare April 4, 2025 22:33
@infiniteflower infiniteflower changed the title feat: bridge solana assets feat (bridge): solana assets Apr 4, 2025
@infiniteflower infiniteflower changed the title feat (bridge): solana assets feat: bridge solana assets Apr 4, 2025
@infiniteflower infiniteflower force-pushed the feat/bridge-solana-button branch from dd0c5be to ef8aafc Compare April 7, 2025 14:58
@infiniteflower infiniteflower force-pushed the mms-1912-bridge-solana-assets branch from 330e61a to 6ef8201 Compare April 7, 2025 14:59
@infiniteflower infiniteflower force-pushed the feat/bridge-solana-button branch from 2c1505f to e75147c Compare April 7, 2025 19:25
@infiniteflower infiniteflower force-pushed the mms-1912-bridge-solana-assets branch from 6ef8201 to bf6e992 Compare April 7, 2025 19:27
@infiniteflower infiniteflower force-pushed the feat/bridge-solana-button branch from 5cb9a95 to d377bbc Compare April 8, 2025 17:48
Base automatically changed from feat/bridge-solana-button to main April 9, 2025 15:36
@infiniteflower infiniteflower force-pushed the mms-1912-bridge-solana-assets branch from bf6e992 to 09034b6 Compare April 9, 2025 16:58
@github-actions

github-actions Bot commented Apr 9, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 09034b6f576b41b902110083c688f46a30a3ea79
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c94e34c5-38e9-4e84-aa36-cc9f0f0b21a4

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

darkwing
darkwing previously approved these changes Apr 9, 2025
View reviewed changes

@darkwing darkwing left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX changes look good!

@infiniteflower
fix: missing dep
d22c04c
@infiniteflower
chore: switch to solana network when selecting solana asset
8a04c3c
@infiniteflower
chore: fix source token select not switching networks properly, switc…
27100cc 
…h networks when only 1 source chain selected
@infiniteflower
chore: refactor NetworkSelector to use useSwitchNetworks for solana
74975e0
@infiniteflower
feat: get solana top tokens from feature flags working
5e38d37
@infiniteflower
feat: append the rest of the bridge tokens to the top tokens list
e1bd3ee
@infiniteflower
chore: formatting
1eeab93
@infiniteflower
chore: refactor var names
c9ee7d4
@infiniteflower
chore: use isSolanaChainId util
183f764
@infiniteflower
wip: fixing tests
f8884f1
@infiniteflower
fix: broken tests
01cf950
@infiniteflower
chore: format
d26651f
@infiniteflower
chore: add solana native and spl tests for useBalance, fix tests
d9b2604
@infiniteflower
fix: lint error
9633934
@infiniteflower
fix: broken tests
ccfec62
@infiniteflower
fix: broken test
a280ea0
@infiniteflower
fix: broken tests
8757cb9
@infiniteflower
fix: broken test
1abea75
@infiniteflower
fix: broken ci
72b4dd0
@infiniteflower
fix: ci issues
9f47054
@infiniteflower
fix: ci issues
04c8d3b
@infiniteflower
fix: ci issues
724d160
@infiniteflower
fix: ci issues
f44b84f
@infiniteflower
fix: ci issues
0a17323
@infiniteflower
fix: ci issues
35f2358
@infiniteflower
fix: ci issues
374ed63
@infiniteflower
fix: ci issues
7f5bdb6
@infiniteflower
chore: update changelog
1a79ab4
@github-actions

github-actions Bot commented Apr 10, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 1a79ab4
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fb0197ba-5d69-4ca6-976e-42a59a621397

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud

sonarqubecloud Bot commented Apr 10, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@micaelae micaelae micaelae left review comments

Copilot code review Copilot Copilot left review comments

@amitabh94 amitabh94 amitabh94 approved these changes

@Matt561 Matt561 Matt561 left review comments

+1 more reviewer

@darkwing darkwing darkwing approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-7.46.0 Issue or pull request that will be included in release 7.46.0 team-swaps-and-bridge Swaps and Bridge team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@infiniteflower @darkwing @amitabh94 @Matt561 @micaelae @metamaskbot