Skip to content

test: update token used in ramps test#14363

Merged
C-Ivan merged 2 commits into
mainfrom
test/update-ramp-used-token
Apr 2, 2025
Merged

test: update token used in ramps test#14363
C-Ivan merged 2 commits into
mainfrom
test/update-ramp-used-token

Conversation

@C-Ivan

@C-Ivan C-Ivan commented Apr 1, 2025

Copy link
Copy Markdown
Contributor

Description

The token being used in a test was displaying an unexpected value in different places and making the smoke fail, I updated the token used to avoid this problem.

Related issues

Fixes: failures in smoke

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

github-actions Bot commented Apr 1, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Apr 1, 2025
@github-actions

github-actions Bot commented Apr 1, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 74f4fa5
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d65f2827-afdd-4408-b207-1f92ad778f96

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@C-Ivan C-Ivan marked this pull request as ready for review April 2, 2025 00:39
@C-Ivan C-Ivan requested a review from a team as a code owner April 2, 2025 00:39
@codecov-commenter

codecov-commenter commented Apr 2, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.25%. Comparing base (9fee6f4) to head (a5ee99a).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #14363   +/-   ##
=======================================
  Coverage   66.25%   66.25%           
=======================================
  Files        2244     2244           
  Lines       47992    47992           
  Branches     6760     6760           
=======================================
  Hits        31797    31797           
  Misses      14178    14178           
  Partials     2017     2017

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud

sonarqubecloud Bot commented Apr 2, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions

github-actions Bot commented Apr 2, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a5ee99a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/204aa0b0-d617-4f90-b923-bbe02d89897f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@C-Ivan C-Ivan added this pull request to the merge queue Apr 2, 2025
Merged via the queue into main with commit 7ed0306 Apr 2, 2025
@C-Ivan C-Ivan deleted the test/update-ramp-used-token branch April 2, 2025 03:55
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 2, 2025
@metamaskbot metamaskbot added the release-7.45.0 Issue or pull request that will be included in release 7.45.0 label Apr 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cortisiko cortisiko cortisiko approved these changes

Assignees

No one assigned

Labels

release-7.45.0 Issue or pull request that will be included in release 7.45.0 team-qa QA team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@C-Ivan @codecov-commenter @cortisiko @metamaskbot