Skip to content

fix: use last selected account's srp index#14352

Merged
montelaidev merged 9 commits into
mainfrom
fix/mmmultisrp-123
Apr 11, 2025
Merged

fix: use last selected account's srp index#14352
montelaidev merged 9 commits into
mainfrom
fix/mmmultisrp-123

Conversation

@montelaidev

@montelaidev montelaidev commented Apr 1, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This pr defaults the selected SRP in to the SRP of the selected account.

Changes:

  1. Updates the AddNewHdAccount to get the keyring of the selected account
  2. Add selectHdKeyringIndexByIdOrDefault and getHdKeyringOfSelectedAccountOrPrimaryKeyring selectors

Related issues

Fixes:

Manual testing steps

  1. Import SRP
  2. Add a new account
  3. Go To add account again and see that the selected SRP is Secret Recovery Phrase 2

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

github-actions Bot commented Apr 1, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-accounts-framework Accounts team label Apr 1, 2025
@github-actions

github-actions Bot commented Apr 2, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: ae8ed14
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8481de5c-9f97-454a-89b2-5d274c44b4df

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@montelaidev montelaidev marked this pull request as ready for review April 2, 2025 23:42
@montelaidev montelaidev requested a review from a team as a code owner April 2, 2025 23:42
@codecov-commenter

codecov-commenter commented Apr 2, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.29%. Comparing base (03f716c) to head (f43dbe1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
app/selectors/multisrp/index.ts 88.23% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #14352   +/-   ##
=======================================
  Coverage   66.28%   66.29%           
=======================================
  Files        2248     2249    +1     
  Lines       48021    48039   +18     
  Branches     6762     6766    +4     
=======================================
+ Hits        31831    31847   +16     
- Misses      14174    14175    +1     
- Partials     2016     2017    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Apr 3, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: f43dbe1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/421e4e66-fcaa-4e67-ad02-5d736930a543

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@github-actions

github-actions Bot commented Apr 7, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a8b5a86
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/12099b2a-359c-416a-8c14-11361eab5b4d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

gantunesr
gantunesr reviewed Apr 9, 2025
View reviewed changes
Comment thread app/selectors/multisrp/index.ts Outdated
Comment thread app/selectors/multisrp/index.ts
Comment thread app/selectors/multisrp/index.ts Outdated
gantunesr
gantunesr reviewed Apr 10, 2025
View reviewed changes
Comment thread app/selectors/multisrp/index.ts Outdated
@sonarqubecloud

sonarqubecloud Bot commented Apr 10, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@montelaidev montelaidev added this pull request to the merge queue Apr 11, 2025
Merged via the queue into main with commit 181fe0f Apr 11, 2025
@montelaidev montelaidev deleted the fix/mmmultisrp-123 branch April 11, 2025 15:12
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 11, 2025
@metamaskbot metamaskbot added the release-7.46.0 Issue or pull request that will be included in release 7.46.0 label Apr 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@gantunesr gantunesr gantunesr approved these changes

Assignees

No one assigned

Labels

release-7.46.0 Issue or pull request that will be included in release 7.46.0 team-accounts-framework Accounts team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@montelaidev @codecov-commenter @gantunesr @metamaskbot @DostoevskysPiano