feat: Create contract interaction entry point component by pedronfigueiredo · Pull Request #14350 · MetaMask/metamask-mobile

pedronfigueiredo · 2025-04-01T10:42:06Z

Description

Includes usage of existing components:

Simulation details
Gas fees component
Origin Row component
Account Details component
Title and subtitle component

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4564

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-04-01T10:42:21Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions · 2025-04-02T14:36:22Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: c4ea9e8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fe290b7c-1f1c-4376-9142-9ed6011701cf

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

jpuri

I left some small feedbacks, will be n ice to address those.

jpuri

I left some small feedbacks, will be nice to address those.

github-actions · 2025-04-04T15:17:01Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: b4a767fe81195a5b02dad66338ce1c231d124458
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6c1c2b65-9271-43f5-b185-26978c3f0b82

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

codecov-commenter · 2025-04-10T10:15:57Z

Codecov Report

Attention: Patch coverage is 80.70175% with 11 lines in your changes missing coverage. Please review.

Project coverage is 66.86%. Comparing base (08382bc) to head (5d46899).
Report is 20 commits behind head on main.

Files with missing lines	Patch %	Lines
...NetworkInfoExpanded/AccountNetworkInfoExpanded.tsx	50.00%	2 Missing and 1 partial ⚠️
...onfirm/Info/Shared/InfoRowOrigin/InfoRowOrigin.tsx	81.25%	0 Missing and 3 partials ⚠️
...s/confirmations/components/Confirm/Title/Title.tsx	66.66%	1 Missing and 1 partial ⚠️
...firmations/hooks/useConfirmationRedesignEnabled.ts	0.00%	2 Missing ⚠️
...ctors/featureFlagController/confirmations/index.ts	90.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #14350      +/-   ##
==========================================
+ Coverage   66.57%   66.86%   +0.28%     
==========================================
  Files        2257     2274      +17     
  Lines       48273    48561     +288     
  Branches     6823     6911      +88     
==========================================
+ Hits        32139    32468     +329     
+ Misses      14102    14044      -58     
- Partials     2032     2049      +17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2025-04-10T10:16:55Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 5d46899
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/94eb0559-2a10-4cee-8994-c9dee3aebfe3

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

joaoloureirop

LGTM

github-actions · 2025-04-15T05:55:55Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: d2b8b26
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bdd39662-2fea-4fca-a364-360037f37314

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

sonarqubecloud · 2025-04-15T06:36:49Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

pedronfigueiredo added the team-confirmations Push issues to confirmations team label Apr 1, 2025

pedronfigueiredo self-assigned this Apr 1, 2025

pedronfigueiredo requested a review from a team as a code owner April 1, 2025 10:42

pedronfigueiredo requested a review from a team April 1, 2025 10:42

pedronfigueiredo requested a review from a team as a code owner April 1, 2025 10:42

pedronfigueiredo force-pushed the pnf/4564 branch 6 times, most recently from af6b366 to c4ea9e8 Compare April 2, 2025 14:19

pedronfigueiredo added the Run Smoke E2E label Apr 2, 2025

jpuri reviewed Apr 3, 2025

View reviewed changes

Comment thread ...ponents/Confirm/AccountNetworkInfo/AccountNetworkInfoExpanded/AccountNetworkInfoExpanded.tsx Outdated

jpuri reviewed Apr 3, 2025

View reviewed changes

Comment thread app/components/Views/confirmations/components/Info/ContractInteraction/ContractInteraction.tsx Outdated

jpuri approved these changes Apr 3, 2025

View reviewed changes

jpuri self-requested a review April 3, 2025 04:55

jpuri requested changes Apr 3, 2025

View reviewed changes

OGPoyraz reviewed Apr 3, 2025

View reviewed changes

pedronfigueiredo force-pushed the pnf/4564 branch 3 times, most recently from e5ac4ed to b4a767f Compare April 4, 2025 12:56

jpuri previously approved these changes Apr 4, 2025

View reviewed changes

OGPoyraz previously approved these changes Apr 4, 2025

View reviewed changes

pedronfigueiredo added Run Smoke E2E and removed Run Smoke E2E labels Apr 4, 2025

OGPoyraz added Run Smoke E2E and removed Run Smoke E2E labels Apr 7, 2025

pedronfigueiredo force-pushed the pnf/4564 branch 2 times, most recently from 8848a53 to 3e89562 Compare April 10, 2025 09:35

fix tests

5d46899

pedronfigueiredo force-pushed the pnf/4564 branch from 3e89562 to 5d46899 Compare April 10, 2025 10:03

pedronfigueiredo added the Run Smoke E2E label Apr 10, 2025

joaoloureirop previously approved these changes Apr 10, 2025

View reviewed changes

joaoloureirop mentioned this pull request Apr 10, 2025

refactor: add feature flag root selector guidelines #14448

Closed

7 tasks

pedronfigueiredo added Run Smoke E2E and removed Run Smoke E2E labels Apr 11, 2025

Fix e2e tests

dce8f2c

OGPoyraz dismissed joaoloureirop’s stale review via dce8f2c April 15, 2025 05:53

OGPoyraz removed the Run Smoke E2E label Apr 15, 2025

Merge branch 'main' into pnf/4564

d2b8b26

OGPoyraz added the Run Smoke E2E label Apr 15, 2025

OGPoyraz added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Apr 15, 2025

OGPoyraz added 2 commits April 15, 2025 08:06

Fix unit test

f30c5c7

Fix unit test 2

eb666cb

metamaskbot added the bitrise-result-ready label Apr 15, 2025

github-actions Bot removed the bitrise-result-ready label Apr 15, 2025

OGPoyraz approved these changes Apr 15, 2025

View reviewed changes

joaoloureirop approved these changes Apr 15, 2025

View reviewed changes

Matt561 self-requested a review April 15, 2025 15:07

Matt561 approved these changes Apr 15, 2025

View reviewed changes

pedronfigueiredo added this pull request to the merge queue Apr 15, 2025

Merged via the queue into main with commit eb400e9 Apr 15, 2025

Uh oh!

Conversation

pedronfigueiredo commented Apr 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions Bot commented Apr 1, 2025

Uh oh!

github-actions Bot commented Apr 2, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

Uh oh!

Uh oh!

jpuri left a comment

Choose a reason for hiding this comment

Uh oh!

jpuri left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 4, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

codecov-commenter commented Apr 10, 2025

Codecov Report

Uh oh!

github-actions Bot commented Apr 10, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

joaoloureirop left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 15, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

sonarqubecloud Bot commented Apr 15, 2025

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

pedronfigueiredo commented Apr 1, 2025 •

edited

Loading

github-actions Bot commented Apr 2, 2025 •

edited by metamaskbot

Loading

github-actions Bot commented Apr 4, 2025 •

edited by metamaskbot

Loading

github-actions Bot commented Apr 10, 2025 •

edited by metamaskbot

Loading

github-actions Bot commented Apr 15, 2025 •

edited by metamaskbot

Loading