Skip to content

feat: add MegaETH Testnet as default network#14241

Merged
stanleyyconsensys merged 35 commits intomainfrom
feat/add-megaeth-testnet
Apr 8, 2025
Merged

feat: add MegaETH Testnet as default network#14241
stanleyyconsensys merged 35 commits intomainfrom
feat/add-megaeth-testnet

Conversation

@stanleyyconsensys
Copy link
Copy Markdown
Contributor

@stanleyyconsensys stanleyyconsensys commented Mar 26, 2025 •
edited
Loading

Description

This PR is to add MegaETH as default network via NetworkController ( 5527, 5495 )

It also include a migration script to add/replace the MegaETH network for existing user

Change:

  • Add MegaETH Testnet to default network via NetworkController options - additionalDefaultNetworks
  • Add migration script to replace/add MegaETH Testnet to the NetworkController state
  • Decouple the logic on method validateName from NetworkSetting to Network Utils isValidNetworkName for easier maintain and increase test coverage
  • Update Unit Test for MegaETH Testnet

Related issues

Fixes:

Manual testing steps

  1. Setup a new wallet
  2. Click on network menu and show test networks
  3. You will see Sepolia , Linea Sepolia and Mega Testnet on test networks section
  4. Click on Mega Testnet to switch the network
  5. Send a transaction
  6. Check the transaction result in the explorer

Screenshots/Recordings

Before

After

Screenshot 2025-03-21 at 12 49 13 Screenshot 2025-03-21 at 12 49 38

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 26, 2025 •
edited
Loading

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@stanleyyconsensys
Copy link
Copy Markdown
Contributor Author

stanleyyconsensys commented Apr 3, 2025

I have read the CLA Document and I hereby sign the CLA

@wantedsystem
Copy link
Copy Markdown
Contributor

wantedsystem commented Apr 3, 2025

I have read the CLA Document and I hereby sign the CLA

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: b33ff08
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1335c0c3-d658-40e3-8f04-9eeadef613a3

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Cal-L
Cal-L approved these changes Apr 8, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@vivek-consensys vivek-consensys added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Apr 8, 2025
@github-project-automation github-project-automation bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Apr 8, 2025
@stanleyyconsensys stanleyyconsensys added this pull request to the merge queue Apr 8, 2025
@stanleyyconsensys stanleyyconsensys removed this pull request from the merge queue due to a manual request Apr 8, 2025
@stanleyyconsensys stanleyyconsensys added this pull request to the merge queue Apr 8, 2025
Merged via the queue into main with commit d9aa8f6 Apr 8, 2025
52 of 62 checks passed
@stanleyyconsensys stanleyyconsensys deleted the feat/add-megaeth-testnet branch April 8, 2025 10:03
@github-project-automation github-project-automation bot moved this from Review finalised - Ready to be merged to Merged, Closed or Archived in PR review queue Apr 8, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2025
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 8, 2025
@metamaskbot metamaskbot added the release-7.45.0 Issue or pull request that will be included in release 7.45.0 label Apr 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Cal-L Cal-L Cal-L approved these changes

@NidhiKJha NidhiKJha NidhiKJha approved these changes

@Battambang Battambang Battambang left review comments

@darkwing darkwing Awaiting requested review from darkwing

Assignees

@stanleyyconsensys stanleyyconsensys

Labels

QA in Progress QA has started on the feature. release-7.45.0 Issue or pull request that will be included in release 7.45.0 team-network-enablement

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@stanleyyconsensys @wantedsystem @darkwing @Cal-L @Battambang @NidhiKJha @metamaskbot @vivek-consensys @mcmire @mathieuartu