Skip to content

fix: bump @metamask/keyring-controller to ^19.2.2#14229

Merged
mikesposito merged 1 commit intomainfrom
mikesposito/bumps/keyring-controller
Mar 25, 2025
Merged

fix: bump @metamask/keyring-controller to ^19.2.2#14229
mikesposito merged 1 commit intomainfrom
mikesposito/bumps/keyring-controller

Conversation

@mikesposito
Copy link
Copy Markdown
Member

@mikesposito mikesposito commented Mar 25, 2025

Description

@metamask/keyring-controller is being updated to 19.2.2 including the following changes:

## [19.2.2]

### Fixed

- Fixed duplication of unsupported keyrings ([#5535](https://github.com/MetaMask/core/pull/5535))
- Enforce keyrings metadata alignment when unlocking existing vault ([#5535](https://github.com/MetaMask/core/pull/5535))
- Fixed frozen object mutation attempt when updating metadata ([#5535](https://github.com/MetaMask/core/pull/5535))

## [19.2.1]

### Changed

- Bump `@metamask/keyring-api"` from `^17.0.0` to `^17.2.0` ([#5366](https://github.com/MetaMask/core/pull/5366))
- Bump `@metamask/keyring-internal-api` from `^4.0.1` to `^4.0.3` ([#5356](https://github.com/MetaMask/core/pull/5356)), ([#5366](https://github.com/MetaMask/core/pull/5366))

### Fixed

- Ensure authorization contract address is provided ([#5353](https://github.com/MetaMask/core/pull/5353))

Related issues

Fixes:

Manual testing steps

  1. Start with an installation from before we introduced keyringsMetadata, proceed past onboarding so that you have a vault setup
  2. Upgrade to this branch
  3. Start the mobile app (without logging in)
  4. Leave the app open a while to give it time to initialize all controllers
  5. Close the app before unlocking
  6. Reopen the app and try to unlock the wallet
  7. Try adding an account

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added the team-wallet-framework-deprecated DEPRECATED: please use "team-core-platform" instead label Mar 25, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 25, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: c50a87f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ed698f00-41d0-4c86-9c47-6dc6b28e3aa6

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@socket-security
Copy link
Copy Markdown

socket-security bot commented Mar 25, 2025

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/keyring-controller@19.2.119.2.2 Transitive: environment +3 805 kB gudahtt

View full report↗︎

@socket-security
Copy link
Copy Markdown

socket-security bot commented Mar 25, 2025

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@metamask/keyring-controller@19.2.2

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@sonarqubecloud
Copy link
Copy Markdown

@mikesposito
Copy link
Copy Markdown
Member Author

@SocketSecurity ignore npm/@metamask/keyring-controller@19.2.2

Published by @Gudahtt

@mikesposito mikesposito marked this pull request as ready for review March 25, 2025 17:04
@mikesposito mikesposito requested a review from a team March 25, 2025 17:04
@mikesposito mikesposito requested a review from a team as a code owner March 25, 2025 17:04
@mikesposito mikesposito added this pull request to the merge queue Mar 25, 2025
Merged via the queue into main with commit 99faccf Mar 25, 2025
52 of 57 checks passed
@mikesposito mikesposito deleted the mikesposito/bumps/keyring-controller branch March 25, 2025 18:03
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2025
@metamaskbot metamaskbot added the release-7.44.0 Issue or pull request that will be included in release 7.44.0 label Mar 25, 2025
@sethkfman sethkfman added release-7.43.0 Issue or pull request that will be included in release 7.43.0 and removed release-7.44.0 Issue or pull request that will be included in release 7.44.0 labels Mar 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.43.0 Issue or pull request that will be included in release 7.43.0 team-wallet-framework-deprecated DEPRECATED: please use "team-core-platform" instead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Sentry] Error: KeyringController - keyring metadata length mismatch

4 participants