Skip to content

fix: when cancelling signature by swiping modal out it should not navigate back#14085

Merged
jpuri merged 1 commit into
mainfrom
conf_reject_fix
Mar 18, 2025
Merged

fix: when cancelling signature by swiping modal out it should not navigate back#14085
jpuri merged 1 commit into
mainfrom
conf_reject_fix

Conversation

@jpuri

@jpuri jpuri commented Mar 18, 2025

Copy link
Copy Markdown
Contributor

Description

When cancelling signature by swiping modal out it should not navigate back

Related issues

Fixes: #13982

Manual testing steps

  1. Go to test dapp
  2. Submit signature
  3. Drag down signature modal
  4. Ensure that signature is rejected and you are still on the dapp

Screenshots/Recordings

TODO

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Mar 18, 2025
@jpuri jpuri requested a review from a team as a code owner March 18, 2025 12:11
@github-actions

github-actions Bot commented Mar 18, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri enabled auto-merge March 18, 2025 12:11
@jpuri jpuri changed the title Fix: when cancelling signature by swiping modal out it should not navigate back fix: when cancelling signature by swiping modal out it should not navigate back Mar 18, 2025
@github-actions

github-actions Bot commented Mar 18, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: b27f79a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2db36db2-68ed-41cc-93d3-3c075dcaed93

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud

sonarqubecloud Bot commented Mar 18, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jpuri jpuri added this pull request to the merge queue Mar 18, 2025
Merged via the queue into main with commit 76db851 Mar 18, 2025
@jpuri jpuri deleted the conf_reject_fix branch March 18, 2025 13:13
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 18, 2025
@metamaskbot metamaskbot added the release-7.44.0 Issue or pull request that will be included in release 7.44.0 label Mar 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes

@vinistevam vinistevam vinistevam approved these changes

Assignees

No one assigned

Labels

release-7.44.0 Issue or pull request that will be included in release 7.44.0 team-confirmations Push issues to confirmations team

Projects

None yet

Milestone

No milestone

4 participants

@jpuri @pedronfigueiredo @vinistevam @metamaskbot